From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: hariharanrangasamy@gmail.com, 26710@debbugs.gnu.org
Subject: bug#26710: Fwd: 25.2; project-find-regexp makes emacs use 100% cpu
Date: Tue, 02 May 2017 20:26:19 +0300 [thread overview]
Message-ID: <838tmfi30k.fsf@gnu.org> (raw)
In-Reply-To: <9474c678-b092-81f0-f5b3-f26d4467ac86@yandex.ru> (message from Dmitry Gutov on Tue, 2 May 2017 13:00:06 +0300)
> Cc: hariharanrangasamy@gmail.com, 26710@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 2 May 2017 13:00:06 +0300
>
> On 02.05.2017 10:15, Eli Zaretskii wrote:
>
> > Can you explain the significance of xref--regexp-syntax-dependent-p's
> > tests? I don't know enough about xref to grasp that just by looking
> > at the changes.
>
> When it returns nil (the regexp is not affected by syntax-table):
>
> If the file containing the hit is not open, we now skip inserting the
> first few lines of that file into the temporary buffer, and calling
> set-auto-mode.
>
> And, whether it's open or not, we skip the syntax-propertize call.
OK, I will look at that function with this in mind.
> Still, if the filter function and sentinel functions take a lot of time
> (and/or get called a lot), like it will be in this example, the UI can't
> as responsive as usual, can it?
The sentinel/filter won't be called at all if keyboard/mouse input is
available. Once they are called, if each call takes a long processing
time, the UI could feel sluggish, yes. But I don't quite see how
using threads will avoid the same problem, since the mechanism for
thread switch is basically the same as for multiplexing UI with
subprocess output.
> I'd like a more general advice first. E.g. do we want to go this road?
IMO, we should first explore the async subprocess road.
> It seems a bit brittle, though: if the process filter is supposed to be
> calling the callback for each item, the callback has to be in place
> right away. And the process will be started before that happens.
You can countermand that by using make-process with the :stop
attribute, then use 'continue-process' when everything is set up.
> We'll probably be saved by filters having to wait until the current
> command finishes executing, though.
Not sure I follow you: a filter function is called whenever some
output arrives from the subprocess. So they don't need to wait for
the subprocess to finish.
next prev parent reply other threads:[~2017-05-02 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a86zu3gf.fsf@hari-laptop.i-did-not-set--mail-host-address--so-tickle-me>
2017-04-29 8:55 ` bug#26710: Fwd: 25.2; project-find-regexp makes emacs use 100% cpu Hariharan Rangasamy
2017-04-29 17:00 ` Dmitry Gutov
2017-04-29 17:37 ` Eli Zaretskii
2017-04-30 4:13 ` Hariharan Rangasamy
2017-04-30 10:35 ` Dmitry Gutov
2017-04-30 18:47 ` Eli Zaretskii
2017-05-01 2:42 ` Dmitry Gutov
2017-05-01 7:20 ` Eli Zaretskii
2017-05-01 21:46 ` Dmitry Gutov
2017-05-02 7:15 ` Eli Zaretskii
2017-05-02 10:00 ` Dmitry Gutov
2017-05-02 17:26 ` Eli Zaretskii [this message]
2017-05-02 17:41 ` Eli Zaretskii
2017-05-03 0:14 ` Dmitry Gutov
2017-05-03 2:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838tmfi30k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=26710@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=hariharanrangasamy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.