From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Sat, 06 May 2017 12:22:21 +0300 Message-ID: <838tmafigi.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494062576 5926 195.159.176.226 (6 May 2017 09:22:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 May 2017 09:22:56 +0000 (UTC) Cc: mvoteiza@udel.edu, emacs-devel@gnu.org, tino.calancha@gmail.com To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 06 11:22:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6vvQ-0001Us-Lt for ged-emacs-devel@m.gmane.org; Sat, 06 May 2017 11:22:52 +0200 Original-Received: from localhost ([::1]:50624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6vvW-0003Mc-9O for ged-emacs-devel@m.gmane.org; Sat, 06 May 2017 05:22:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6vvN-0003MW-G0 for emacs-devel@gnu.org; Sat, 06 May 2017 05:22:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6vvK-00050W-Cw for emacs-devel@gnu.org; Sat, 06 May 2017 05:22:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6vvK-00050O-9a; Sat, 06 May 2017 05:22:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2589 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d6vvJ-0006OO-Gy; Sat, 06 May 2017 05:22:45 -0400 In-reply-to: <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> (message from Jean-Christophe Helary on Sat, 6 May 2017 18:02:37 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214610 Archived-At: > From: Jean-Christophe Helary > Date: Sat, 6 May 2017 18:02:37 +0900 > Cc: Mark Oteiza , emacs-devel > > > +(defsubst string-trim-left (string &optional regexp) > > + "Trim STRING of leading whitespace matching REGEXP. > > + > > +REGEXP defaults to \"[ \t\n\r]+\"." > > + (if (string-match (concat "\\`" (or regexp "[ \t\n\r]+")) string) > > (replace-match "" t t string) > > string)) > > What I did not like in the original design was that the default regexp was hard-coded (besides for the fact that it did not allow for options). I understand that your proposal *only* makes it the default, but I think it would be more elegant to have the default extracted from the code and visible to the user so as to allow for her to over-ride the default by resetting the value. Can you tell why you think that defconst is more elegant than a hard-coded default? I think they are basically the same.