From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26959: Feature request: bold underlines Date: Thu, 18 May 2017 07:10:47 +0300 Message-ID: <838tlu6bzs.fsf@gnu.org> References: <83h90j5w72.fsf@gnu.org> <6ad09d0f-d9e5-d544-f2e1-a7bf561556f6@live.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1495080732 32259 195.159.176.226 (18 May 2017 04:12:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 May 2017 04:12:12 +0000 (UTC) Cc: 26959@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 18 06:12:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBCnF-0008FW-Az for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 May 2017 06:12:05 +0200 Original-Received: from localhost ([::1]:51661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBCnK-000899-Ur for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 May 2017 00:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBCnF-00087M-J3 for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 00:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBCnC-0002W0-Ej for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 00:12:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBCnC-0002Vw-B3 for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 00:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dBCnC-0002Vy-6O for bug-gnu-emacs@gnu.org; Thu, 18 May 2017 00:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2017 04:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26959-submit@debbugs.gnu.org id=B26959.14950806669595 (code B ref 26959); Thu, 18 May 2017 04:12:02 +0000 Original-Received: (at 26959) by debbugs.gnu.org; 18 May 2017 04:11:06 +0000 Original-Received: from localhost ([127.0.0.1]:51664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBCmH-0002Uf-KR for submit@debbugs.gnu.org; Thu, 18 May 2017 00:11:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBCmG-0002UA-E8 for 26959@debbugs.gnu.org; Thu, 18 May 2017 00:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBCm7-0002Mh-R8 for 26959@debbugs.gnu.org; Thu, 18 May 2017 00:10:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBCm7-0002Mb-FG; Thu, 18 May 2017 00:10:55 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4908 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dBCm6-0007IL-Nq; Thu, 18 May 2017 00:10:55 -0400 In-reply-to: <6ad09d0f-d9e5-d544-f2e1-a7bf561556f6@live.com> (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel on Wed, 17 May 2017 14:59:56 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132591 Archived-At: > Cc: 26959@debbugs.gnu.org > From: Clément Pit--Claudel > Date: Wed, 17 May 2017 14:59:56 -0400 > > > What all this means is that currently the exact visual effect of the > > underline attribute is deliberately not well-defined: about the only > > thing you can rely on is that you will get a horizontal line somewhere > > in the lower portion of the characters. > > > > Implementing your suggestion would require that we define the behavior > > much better, which is not easy given the different font drivers and > > fonts, on which the user has almost no control. E.g., we will need to > > decide whether thickness customization overrides the font-dependent > > scaling, and if not, how these two play together. And if we want to > > allow customization of the underline position (why not?), we will have > > to decide what to do with it when the font size changes. And then we > > will need to decide what to do if the font doesn't support scaling. > > That makes sense, but I'm not sure all of this is needed. I agree that it would be nice, but is it really necessary? Perhaps not. But any subset of this we choose to implement should be consistent and should make sense to users. > In terms of code, my suggestion would translate into multiplying the `thickness' variable in xftfont by 2 when :bold t is specified in the underline's property list. Even if the bold attribute starts in the middle of a consecutive run of underlined characters? IOW, should this override the current behavior of computing the thickness only once per such run?