From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file Date: Sat, 28 Oct 2017 19:41:33 +0300 Message-ID: <838tfv5io2.fsf@gnu.org> References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> <83a80b5knv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1509208939 28283 195.159.176.226 (28 Oct 2017 16:42:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Oct 2017 16:42:19 +0000 (UTC) Cc: 29040@debbugs.gnu.org To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 28 18:42:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8UBW-0006Ok-42 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Oct 2017 18:42:10 +0200 Original-Received: from localhost ([::1]:33412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8UBd-0000mx-IC for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Oct 2017 12:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8UBS-0000kn-TM for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 12:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8UBO-0002F5-11 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 12:42:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58951) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8UBN-0002Er-TY for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 12:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e8UBN-0000Zl-NL for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 12:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2017 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29040 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29040-submit@debbugs.gnu.org id=B29040.15092089152201 (code B ref 29040); Sat, 28 Oct 2017 16:42:01 +0000 Original-Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 16:41:55 +0000 Original-Received: from localhost ([127.0.0.1]:39399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8UBF-0000ZN-L3 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 12:41:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8UBE-0000ZA-2v for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 12:41:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8UB4-00024l-34 for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 12:41:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8UB3-00024f-Vj; Sat, 28 Oct 2017 12:41:42 -0400 Original-Received: from [176.228.60.248] (port=1086 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e8UB2-0002BI-St; Sat, 28 Oct 2017 12:41:41 -0400 In-reply-to: (message from Richard Copley on Sat, 28 Oct 2017 17:16:14 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139116 Archived-At: > From: Richard Copley > Date: Sat, 28 Oct 2017 17:16:14 +0100 > Cc: 29040@debbugs.gnu.org > > > Actually, I think it was caused by 015f0bb. Does the patch below fix > > the problem? Please actually check the alignment of getcjmp, not just > > that the crashes went away. > > > > diff --git a/src/thread.c b/src/thread.c > > index 6f12d79..2520771 100644 > > --- a/src/thread.c > > +++ b/src/thread.c > > @@ -26,7 +26,11 @@ along with GNU Emacs. If not, see . */ > > #include "coding.h" > > #include "syssignal.h" > > > > -static struct thread_state alignas (GCALIGNMENT) main_thread; > > +#define COMMON_MULTIPLE(a, b) \ > > + ((a) % (b) == 0 ? (a) : (b) % (a) == 0 ? (b) : (a) * (b)) > > +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALIGNMENT) > > + > > +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; > > > > struct thread_state *current_thread = &main_thread; > > Looks good. There's no crash and getcjmp is aligned: > > Thread 1 hit Breakpoint 3, quit_throw_to_read_char ( > from_signal=from_signal@entry=false) at keyboard.c:10548 > 10548 sys_longjmp (getcjmp, 1); > (gdb) p &getcjmp > $1 = (sys_jmp_buf *) 0x4005cdaf0 Thanks, I installed that. If the problem doesn't come back, please close the bug.