From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30699: 26.0.91; buffer contents flicker on macOS frames when frames are resized Date: Mon, 19 Mar 2018 17:27:42 +0200 Message-ID: <838taonl01.fsf@gnu.org> References: <20180309120952.GA45581@breton.holly.idiocy.org> <837eqlwf1i.fsf@gnu.org> <20180309232415.GB51893@breton.holly.idiocy.org> <20180310002555.GA54231@breton.holly.idiocy.org> <83h8pouycc.fsf@gnu.org> <20180310230706.GB55832@breton.holly.idiocy.org> <83a7vetw32.fsf@gnu.org> <20180312004638.GA56747@breton.holly.idiocy.org> <20180314150858.GA82855@breton.holly.idiocy.org> <20180319151552.GA32506@breton.holly.idiocy.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1521473171 8429 195.159.176.226 (19 Mar 2018 15:26:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Mar 2018 15:26:11 +0000 (UTC) Cc: 30699@debbugs.gnu.org, aaronjensen@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 19 16:26:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exwfl-00023o-Rw for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Mar 2018 16:26:05 +0100 Original-Received: from localhost ([::1]:42554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwhp-0005Wd-1y for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Mar 2018 11:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwhh-0005VH-5I for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 11:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exwhe-0005NS-0G for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 11:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exwhd-0005N9-Rq for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 11:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1exwhd-0003ni-LI for bug-gnu-emacs@gnu.org; Mon, 19 Mar 2018 11:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Mar 2018 15:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30699-submit@debbugs.gnu.org id=B30699.152147326414588 (code B ref 30699); Mon, 19 Mar 2018 15:28:01 +0000 Original-Received: (at 30699) by debbugs.gnu.org; 19 Mar 2018 15:27:44 +0000 Original-Received: from localhost ([127.0.0.1]:42045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exwhL-0003nD-Sb for submit@debbugs.gnu.org; Mon, 19 Mar 2018 11:27:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exwhJ-0003n0-Kv for 30699@debbugs.gnu.org; Mon, 19 Mar 2018 11:27:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exwhB-0005D6-DC for 30699@debbugs.gnu.org; Mon, 19 Mar 2018 11:27:36 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exwhB-0005D0-8u; Mon, 19 Mar 2018 11:27:33 -0400 Original-Received: from [176.228.60.248] (port=2910 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1exwhA-0005mq-Mu; Mon, 19 Mar 2018 11:27:33 -0400 In-reply-to: <20180319151552.GA32506@breton.holly.idiocy.org> (message from Alan Third on Mon, 19 Mar 2018 15:15:52 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144409 Archived-At: > Date: Mon, 19 Mar 2018 15:15:52 +0000 > From: Alan Third > Cc: Eli Zaretskii , 30699@debbugs.gnu.org > > I’ve attached a new version of the patch. > > Eli, I left the global variable as static since as far as I can tell > static global variables are still global to all threads, which is the > behaviour I believe we want. These functions should only be called > from the main thread anyway, Cocoa will kill the thread if GUI calls > are made from non‐main threads. > > If it definitely shouldn’t be static, what should I do with it? > > I moved the call to ns_enable_screen_updates in unwind_redisplay as > that’s where the double buffering code appears to unblock updates. It's fine with me to install this on master, and see if there are any adverse effects. Thanks.