From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Accept plists when serializing and parsing JSON
Date: Fri, 08 Jun 2018 17:45:29 +0300
Message-ID: <838t7puyk6.fsf@gnu.org>
References: <87sh6awls5.fsf@gmail.com> <83o9gug811.fsf@gnu.org>
	<87d0xaozl1.fsf@gmail.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Trace: blaine.gmane.org 1528469064 14611 195.159.176.226 (8 Jun 2018 14:44:24 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 8 Jun 2018 14:44:24 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 08 16:44:20 2018
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1fRIcm-0003gB-4E
	for ged-emacs-devel@m.gmane.org; Fri, 08 Jun 2018 16:44:20 +0200
Original-Received: from localhost ([::1]:36289 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1fRIet-0001rC-49
	for ged-emacs-devel@m.gmane.org; Fri, 08 Jun 2018 10:46:31 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1fRIdz-0001pi-3p
	for emacs-devel@gnu.org; Fri, 08 Jun 2018 10:45:36 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1fRIdw-0007Yn-28
	for emacs-devel@gnu.org; Fri, 08 Jun 2018 10:45:35 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58843)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1fRIdv-0007YS-Qd; Fri, 08 Jun 2018 10:45:31 -0400
Original-Received: from [176.228.60.248] (port=1593 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1fRIdu-0001Vj-IL; Fri, 08 Jun 2018 10:45:31 -0400
In-reply-to: <87d0xaozl1.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?=
	=?utf-8?B?VMOhdm9yYQ==?= on Sat, 02 Jun 2018 00:29:30 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:226124
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/226124>

> From: João Távora <joaotavora@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 02 Jun 2018 00:29:30 +0100
> 
> New patch after my sig

Thanks.  Apart of some missing spaces before opening paren, like here:

> +                  strcpy(&keyword_key_str[1],key_str);
> +                  Lisp_Object key = intern_1(keyword_key_str,strlen(key_str)+1);

This looks good to go, unless you still have unresolved issues wrt
comments by others.