all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Cc: Radon Rosborough <radon.neon@gmail.com>
Subject: Blink Cursor mode is off by default
Date: Mon, 11 Jun 2018 19:48:51 +0300	[thread overview]
Message-ID: <838t7lqnf0.fsf@gnu.org> (raw)

Commit 2db57579b08ac99c464b6d3698648b3167fc5d55 caused what the
Subject says: blink-cursor-mode is now off by default on GUI frames.
(I see this on Windows, but I cannot imagine it is any different on
other GUI platforms.)  (Judging by lack of complaints, perhaps we
should just turn that mode off by default ;-)

It happened because that commit moved the call to
custom-reevaluate-setting to an earlier place during startup, and the
initial window-system is not yet set up at that place.  So the
condition in blink-cursor-mode evaluates to nil, and the mode is
disabled.

I can see several ways out of this:

  . Move the call to custom-reevaluate-setting back where it was, and
    instead call custom-reevaluate-setting in that earlier place only
    for Info-default-directory-list, which was the original reason why
    the call was moved;
  . Add a call to custom-reevaluate-setting for blink-cursor-mode
    where the window-system is already set up;
  . Call custom-reevaluate-setting for all the delayed-init variables
    twice: once where we do that now, and again where we did that
    before the above commit;
  . Introduce yet another variable similar to
    custom-delayed-init-variables, but separate from it, and put on
    it all the delayed-init variables that need the window-system to
    be set up, leaving all the rest in custom-delayed-init-variables.

I tend to favor the 3rd alternative, as it is relatively easy and at
the same time reliable.  The first two mean a significant maintenance
burden to consider each new variable whether it needs an additional
evaluation after window-system setup; the last alternative is maybe
too complex.

Comments?



             reply	other threads:[~2018-06-11 16:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 16:48 Eli Zaretskii [this message]
2018-06-11 17:14 ` Blink Cursor mode is off by default Stefan Monnier
2018-06-11 17:32   ` Eli Zaretskii
2018-06-11 22:13     ` Stefan Monnier
2018-06-11 23:19       ` dancol
2018-06-12  2:31         ` Eli Zaretskii
2018-06-12  2:33           ` Daniel Colascione
2018-06-12  4:02             ` Eli Zaretskii
2018-06-12  4:12               ` dancol
2018-06-12 15:20                 ` Eli Zaretskii
2018-06-12 15:52                   ` Stefan Monnier
2018-06-12 16:40                     ` Eli Zaretskii
2018-06-12 16:51                       ` dancol
2018-06-15 14:14                 ` Yes, please allow pre-configuration of first frame [was: Blink Cursor mode is off by default] N. Jackson
2018-06-15 14:31                   ` Eli Zaretskii
2018-06-15 21:34                   ` Stefan Monnier
2018-06-16 14:37                     ` Daniel Colascione
2018-06-16 17:20                       ` Stefan Monnier
2018-06-16 17:26                         ` Eli Zaretskii
2018-06-16 17:33                           ` Daniel Colascione
2018-06-12 15:24               ` Blink Cursor mode is off by default Stefan Monnier
2018-06-12  2:29       ` Eli Zaretskii
2018-06-11 20:43 ` Michael Heerdegen
2018-06-12  2:26   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838t7lqnf0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=radon.neon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.