From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: pcase: Semantics of atom QPATS Date: Sat, 16 Jun 2018 10:49:19 +0300 Message-ID: <838t7f188w.fsf@gnu.org> References: <87tvqbjwyf.fsf@web.de> <87k1r3qro3.fsf@web.de> <87vaaj9y4b.fsf@web.de> <83d0wr1ami.fsf@gnu.org> <87zhzvtced.fsf@web.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1529135302 8417 195.159.176.226 (16 Jun 2018 07:48:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 07:48:22 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 09:48:18 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fU5wX-00024X-DL for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 09:48:17 +0200 Original-Received: from localhost ([::1]:50574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5ye-0006M2-L7 for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 03:50:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5xm-0006Lw-8d for emacs-devel@gnu.org; Sat, 16 Jun 2018 03:49:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fU5xh-0005QW-B6 for emacs-devel@gnu.org; Sat, 16 Jun 2018 03:49:34 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fU5xh-0005Pi-6M; Sat, 16 Jun 2018 03:49:29 -0400 Original-Received: from [176.228.60.248] (port=2949 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fU5xg-0007Rl-I2; Sat, 16 Jun 2018 03:49:28 -0400 In-reply-to: <87zhzvtced.fsf@web.de> (message from Michael Heerdegen on Sat, 16 Jun 2018 09:32:10 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226350 Archived-At: > From: Michael Heerdegen > Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org > Date: Sat, 16 Jun 2018 09:32:10 +0200 > > Eli Zaretskii writes: > > > > Ok. Is this patch ok for emacs-26? > > > > Changes in documentation and comments are always okay there, but I'm > > uneasy with changes that modify behavior. Why is it important to > > support non-integer numbers in Emacs 26.2? > > It's not important, no I thought it would be harmless, but master is ok > for me. Then let's do this on master, please. > > > - ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat) > > > + ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat) > > > > Any reasons to use numberp and not number-or-marker-p? > > Is it likely that someone constructs a pcase pattern with a literal > marker in it? I have no idea.