all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: pcase: Semantics of atom QPATS
Date: Sat, 16 Jun 2018 10:49:19 +0300	[thread overview]
Message-ID: <838t7f188w.fsf@gnu.org> (raw)
In-Reply-To: <87zhzvtced.fsf@web.de> (message from Michael Heerdegen on Sat, 16 Jun 2018 09:32:10 +0200)

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: monnier@IRO.UMontreal.CA,  emacs-devel@gnu.org
> Date: Sat, 16 Jun 2018 09:32:10 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > > Ok.  Is this patch ok for emacs-26?
> >
> > Changes in documentation and comments are always okay there, but I'm
> > uneasy with changes that modify behavior.  Why is it important to
> > support non-integer numbers in Emacs 26.2?
> 
> It's not important, no I thought it would be harmless, but master is ok
> for me.

Then let's do this on master, please.

> > > -   ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat)
> > > +   ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat)
> >
> > Any reasons to use numberp and not number-or-marker-p?
> 
> Is it likely that someone constructs a pcase pattern with a literal
> marker in it?

I have no idea.



  reply	other threads:[~2018-06-16  7:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10  0:40 pcase: Semantics of atom QPATS Michael Heerdegen
2018-06-11 14:09 ` Stefan Monnier
2018-06-11 14:45   ` Drew Adams
2018-06-11 15:24     ` Stefan Monnier
2018-06-11 20:53   ` Michael Heerdegen
2018-06-13  3:41   ` Michael Heerdegen
2018-06-13 12:52     ` Stefan Monnier
2018-06-16  4:03       ` Michael Heerdegen
2018-06-16  6:57         ` Eli Zaretskii
2018-06-16  7:32           ` Michael Heerdegen
2018-06-16  7:49             ` Eli Zaretskii [this message]
2018-06-17 13:35               ` Michael Heerdegen
2018-06-16 13:42             ` Noam Postavsky
2018-06-16 12:57           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838t7f188w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.