From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents Date: Sat, 21 Jul 2018 21:35:53 +0300 Message-ID: <838t64xwqe.fsf@gnu.org> References: <20180721180616.6608.26581@vcs0.savannah.gnu.org> <20180721180618.5CEA9208D4@vcs0.savannah.gnu.org> <83bmb0xxcy.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532198072 6885 195.159.176.226 (21 Jul 2018 18:34:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Jul 2018 18:34:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 21 20:34:28 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgwi4-0001gF-0J for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2018 20:34:28 +0200 Original-Received: from localhost ([::1]:53615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgwkA-0001Jf-TC for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2018 14:36:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgwjU-0001JY-06 for emacs-devel@gnu.org; Sat, 21 Jul 2018 14:35:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgwjQ-0004bj-Sh for emacs-devel@gnu.org; Sat, 21 Jul 2018 14:35:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgwjQ-0004bf-Oi; Sat, 21 Jul 2018 14:35:52 -0400 Original-Received: from [176.228.60.248] (port=4191 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgwjQ-0006kD-3o; Sat, 21 Jul 2018 14:35:52 -0400 In-reply-to: (message from Stefan Monnier on Sat, 21 Jul 2018 14:29:27 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227635 Archived-At: > From: Stefan Monnier > Date: Sat, 21 Jul 2018 14:29:27 -0400 > > > I don't understand your claims, sorry. Is the code wrong, or are the > > comments wrong? > > I don't understand enough of the code to have an opinion on it, but the > comments describe a behavior which would be wrong: both before-c-f and > after-c-f- need to be run for any buffer change, even if it's only an > insertion or only a deletion. What if there's no change at all, i.e. no deletions and no insertions? That was the OP's recipe. > > And what would you expect to see in the buffer > > modification hooks calls for the recipe of that bug? > > Lots of options, but basically: one call to b-c-f with FROM being < then > the first position at which a deletion or insertion will take place and > TO being after the last such position (e.g. from==to if the change is > a single insertion); followed by one call to a-c-f with the > same constraints (e.g. from==to if it's a single deletion). You did read the bug report, didn't you? Because unless I completely misunderstand what you are saying, you are not describing the bug's recipe.