From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0 Date: Fri, 17 Aug 2018 17:32:13 +0300 Message-ID: <838t55gj2q.fsf@gnu.org> References: <86a7q0ai2z.fsf@gmail.com> <6d36dc4c-1e14-b6c8-e2f0-911d08f759e1@cs.ucla.edu> <83in4os01j.fsf@gnu.org> <16f2754a-b40e-4bc4-f95a-9bada460d5a4@cs.ucla.edu> <83bma9mh3z.fsf@gnu.org> <86eff52njj.fsf@gmail.com> <83wosxkwfz.fsf@gnu.org> <864lg1rlp0.fsf@gmail.com> <83mutslt8f.fsf@gnu.org> <86in4gixg3.fsf@gmail.com> <83d0uolpxt.fsf@gnu.org> <86600giwct.fsf@gmail.com> <861sb4iv2d.fsf@gmail.com> <838t5clnxk.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534518780 2773 195.159.176.226 (17 Aug 2018 15:13:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2018 15:13:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 17:12:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqgQp-0000aK-Dh for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2018 17:12:55 +0200 Original-Received: from localhost ([::1]:34667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqgSu-0004T3-31 for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2018 11:15:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqfng-00069B-01 for emacs-devel@gnu.org; Fri, 17 Aug 2018 10:32:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqfnc-0001vF-0o for emacs-devel@gnu.org; Fri, 17 Aug 2018 10:32:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqfnb-0001vA-TC; Fri, 17 Aug 2018 10:32:23 -0400 Original-Received: from [176.228.60.248] (port=2819 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fqfnb-0000zp-DS; Fri, 17 Aug 2018 10:32:23 -0400 In-reply-to: (message from Andy Moreton on Tue, 14 Aug 2018 13:59:08 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228642 Archived-At: > From: Andy Moreton > Date: Tue, 14 Aug 2018 13:59:08 +0100 > > The attached patch fixes the -Wcast-function-type warnings when building > on Windows MSYS2 64bit (GCC 8.2.0) with "-Og". Theere is one remaining > compiler warning: > > C:/emacs/git/emacs/master/src/w32fns.c: In function 'Fw32_read_registry': > C:/emacs/git/emacs/master/src/w32fns.c:10142:21: warning: 'rootkey' may be used uninitialized in this function [-Wmaybe-uninitialized] > Lisp_Object val = w32_read_registry (NILP (root) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ? HKEY_CURRENT_USER > ~~~~~~~~~~~~~~~~~~~ > : rootkey, > ~~~~~~~~~~ > key, name); > ~~~~~~~~~~ Thanks, pushed to the master branch. I just made the new function's name a bit shorter.