From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Window tree and window's internal height Date: Mon, 19 Nov 2018 20:36:24 +0200 Message-ID: <838t1okj87.fsf@gnu.org> References: <83o9anuahg.fsf@gnu.org> <5BF06068.60103@gmx.at> <83bm6mtm9l.fsf@gnu.org> <5BF1C03B.2030801@gmx.at> <834lcet9pf.fsf@gnu.org> <5BF2852F.7010400@gmx.at> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1542652468 7560 195.159.176.226 (19 Nov 2018 18:34:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2018 18:34:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 19 19:34:24 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gOoNM-0001s2-AW for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2018 19:34:24 +0100 Original-Received: from localhost ([::1]:58568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOoPS-0008DU-Vv for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2018 13:36:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOoPI-0008CI-5F for emacs-devel@gnu.org; Mon, 19 Nov 2018 13:36:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOoPF-0003RB-0d for emacs-devel@gnu.org; Mon, 19 Nov 2018 13:36:24 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOoPE-0003R7-Tz; Mon, 19 Nov 2018 13:36:20 -0500 Original-Received: from [176.228.60.248] (port=2600 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gOoPD-0003AM-MZ; Mon, 19 Nov 2018 13:36:20 -0500 In-reply-to: <5BF2852F.7010400@gmx.at> (message from martin rudalics on Mon, 19 Nov 2018 10:41:03 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231236 Archived-At: > Date: Mon, 19 Nov 2018 10:41:03 +0100 > From: martin rudalics > CC: emacs-devel@gnu.org > > > I thought of saying something like > > > > The minibuffer window does not have a parent window, but it > > nevertheless is a sibling of the frame's root window, and thus can > > be reached via window-next-sibling. > > I'd start the sentence with "A minibuffer window that is not alone on > its frame ..." but for the rest it's fine with me. Thanks, I used that. > > I don't. I've read the description of the window tree, and thought > > "this is a single window on its TTY frame, it cannot possibly have > > anything non-nil pointed to by its 'next' pointer". Oops! > > So sometimes such details are important in the manual. Still, I > wouldn't rely on the Elisp manual to tell me anything about the > underlying C structures. Well, I turned to the manual after becoming disappointed in the comments to 'struct window' definition... > > No. The code is very unequivocal: > > > > /* If we must, use the pixel-based version which is much slower than > > the line-based one but can handle varying line heights. */ > > if (FRAME_WINDOW_P (XFRAME (XWINDOW (window)->frame))) <<<<<<<<<< > > window_scroll_pixel_based (window, n, whole, noerror); > > else > > window_scroll_line_based (window, n, whole, noerror); > > The code is unequivocal, the comment leaves much room to > interpretation. I made it more clear now.