From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34350: 27.0.50; ediff-revision broken with SVN backend + non ascii chars both in directory and in filename Date: Fri, 08 Feb 2019 23:45:01 +0200 Message-ID: <838syqosyq.fsf@gnu.org> References: <84d0o4zoc9.fsf@gmail.com> <83va1vr41l.fsf@gnu.org> <622e6df3-fb17-cf8a-a166-23fd1549a6c7@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="208163"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34350@debbugs.gnu.org, monnier@iro.umontreal.ca, vincent.belaiche@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 08 22:46:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gsDyN-000rr5-BA for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Feb 2019 22:46:11 +0100 Original-Received: from localhost ([127.0.0.1]:35646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsDyM-0006fx-Cd for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Feb 2019 16:46:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsDyF-0006fq-Tt for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 16:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gsDyF-0008U8-3u for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 16:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gsDyF-0008Ta-0P for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 16:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gsDyE-0008FW-Fg for bug-gnu-emacs@gnu.org; Fri, 08 Feb 2019 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Feb 2019 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34350 X-GNU-PR-Package: emacs Original-Received: via spool by 34350-submit@debbugs.gnu.org id=B34350.154966234730856 (code B ref 34350); Fri, 08 Feb 2019 21:46:02 +0000 Original-Received: (at 34350) by debbugs.gnu.org; 8 Feb 2019 21:45:47 +0000 Original-Received: from localhost ([127.0.0.1]:40218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gsDxz-00081G-H5 for submit@debbugs.gnu.org; Fri, 08 Feb 2019 16:45:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gsDxw-0007ta-VW for 34350@debbugs.gnu.org; Fri, 08 Feb 2019 16:45:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gsDxd-00080N-0U; Fri, 08 Feb 2019 16:45:29 -0500 Original-Received: from [176.228.60.248] (port=3903 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gsDxa-0005MV-3o; Fri, 08 Feb 2019 16:45:24 -0500 In-reply-to: <622e6df3-fb17-cf8a-a166-23fd1549a6c7@yandex.ru> (message from Dmitry Gutov on Fri, 8 Feb 2019 20:25:35 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155276 Archived-At: > Cc: 34350@debbugs.gnu.org, vincent.belaiche@gmail.com > From: Dmitry Gutov > Date: Fri, 8 Feb 2019 20:25:35 +0300 > > On 07.02.2019 18:50, Eli Zaretskii wrote: > > > Any idea why it insists on disabling code-conversions? > > This was well before my time, and the only people I remember messing > with these variables anywhere in VC ever since are you (for > Windows-related fixes) and Michael. So this might require some digging > with vc-annotate. How is vc-annotate relevant to vc-git-find-revision and the issue at hand? The last thing vc-find-revision does is to visit the file written by the back-end, and it visits it normally, with find-file-noselect, which decodes the contents as usual. The problems I see are with forcing no-conversion in the intermediate operations in the back-end, where it extracts the specified version to a buffer. > Also note that this affects two commands: one that returns the file > name, and another, its contents. I'm not sure what encoding 'git > cat-file blob' outputs in. We already have in vc-git a variable that holds that encoding (UTF-8 by default). > > In addition to producing undecoded buffer, these bindings have the > > adverse effect of forcing Emacs not to encode command-line arguments > > we pass to the VCS, which is the immediate cause for the current bug. > > The adverse effect sounds like a separate bug. It's not a bug, it's a documented feature. coding-system-for-write affects both I/O from and to a subprocess and the encoding of the command-line arguments we pass to that subprocess. That's why we should be extra-careful when binding coding-system-for-write around invocations of other programs.