From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH 0/4] Trivial code cleanups Date: Mon, 01 Apr 2019 17:34:46 +0300 Message-ID: <838swthjzt.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190331223742.1351-1-Hi-Angel@yandex.ru> <83d0m6gx30.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="184581"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, Hi-Angel@yandex.ru To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 01 16:41:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAy89-000lwM-Qj for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 16:41:45 +0200 Original-Received: from localhost ([127.0.0.1]:41682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAy88-0005yw-Pb for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Apr 2019 10:41:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAy1g-0001MX-H5 for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 10:35:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAy1f-0001mh-BN for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 10:35:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54489) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAy1e-0001mR-Rz for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 10:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAy1e-0000vv-LC for bug-gnu-emacs@gnu.org; Mon, 01 Apr 2019 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Apr 2019 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.15541292903554 (code B ref 35062); Mon, 01 Apr 2019 14:35:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 1 Apr 2019 14:34:50 +0000 Original-Received: from localhost ([127.0.0.1]:39800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAy1R-0000vG-Of for submit@debbugs.gnu.org; Mon, 01 Apr 2019 10:34:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAy1O-0000v0-92 for 35062@debbugs.gnu.org; Mon, 01 Apr 2019 10:34:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAy1J-0001gh-2R; Mon, 01 Apr 2019 10:34:41 -0400 Original-Received: from [176.228.60.248] (port=2042 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hAy1E-0004Fa-Rd; Mon, 01 Apr 2019 10:34:39 -0400 In-reply-to: (message from Robert Pluim on Mon, 01 Apr 2019 15:27:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157028 Archived-At: > From: Robert Pluim > Cc: Konstantin Kharlamov , 35062@debbugs.gnu.org > Date: Mon, 01 Apr 2019 15:27:59 +0200 > > Iʼd prefer it if the effort went to determining if eg the alert for > 'type = 2' below was correct or not Isn't it clear? Btw, AFAICT, that function is _always_ called with type == 2 in xterm.c, never with any other value. Only its other implementations can be called with a different value of TYPE.