From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com
Subject: bug#35739: Bad signature from GNU ELPA
Date: Thu, 23 May 2019 07:52:46 +0300 [thread overview]
Message-ID: <838sux7owx.fsf@gnu.org> (raw)
In-Reply-To: <jwvsgt54yed.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 23 May 2019 00:06:19 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: rcopley@gmail.com, 35739@debbugs.gnu.org, npostavs@gmail.com
> Date: Thu, 23 May 2019 00:06:19 -0400
>
> > Where is the decoding happening, then? According to what you write,
> > URL should just save the files as is, and then decoding should happen
> > when we access the resulting files after saving them. Is that what
> > happens after the changes?
>
> That's right.
>
> > Sorry for the typo: I meant list-packages. Does that display come
> > from the README files?
>
> It can come from various places, but the only case affected by my change
> is when it comes from the remote archive in which case it's indeed the
> *-readme.txt file that I do decode explicitly.
>
> > Other clients might need it in other ways. From what you explain, it
> > sounds like package.el doesn't need to decode at all when it
> > downloads, so it should disregard the 'charset' header and always
> > treat the stuff it gets as a raw byte stream. Is that correct?
>
> That's right.
Sounds good, thanks.
> > If it is correct, then there's no need to make any changes in
> > url*.el routines.
>
> There is, because the routine that extracts the "raw bytes" is url-insert
> which (until my patch) also did the decoding according to the "charset"
> specified in the HTTP headers returned by the server (if present).
> IOW it didn't always return the raw bytes.
Then how about an optional argument to disable 'charset' handling
instead? That'd be backward-compatible.
> Note that other clients will only be negatively affected by the change if:
> - the HTTP server has returned a "charset" in its headers.
> - they url-insert into a unibyte buffer.
> - they need the text to be decoded.
> The last two points should be mutually exclusive in sane situations, so
> I think the change is pretty safe. Or to put it another way, I think
> it's more likely to uncover or even fix a bug than to introduce one.
I'd prefer a backward-compatible change, because that saves us from
the need to be 100% right when estimating the collateral damage,
something that we have failed in several cases in the past.
Thanks.
next prev parent reply other threads:[~2019-05-23 4:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 21:25 bug#35739: Bad signature from GNU ELPA Richard Copley
2019-05-14 21:37 ` bug#35739: Acknowledgement (Bad signature from GNU ELPA) Richard Copley
2019-05-14 22:04 ` bug#35739: Bad signature from GNU ELPA Noam Postavsky
2019-05-14 22:26 ` Richard Copley
2019-05-14 22:42 ` Richard Copley
2019-05-15 2:42 ` Eli Zaretskii
2019-05-15 7:13 ` Richard Copley
2019-05-15 14:03 ` Stefan Monnier
2019-05-15 15:03 ` Eli Zaretskii
2019-05-18 22:36 ` Stefan Monnier
2019-05-22 5:19 ` Eli Zaretskii
2019-05-22 16:20 ` Stefan Monnier
2019-05-22 17:09 ` Eli Zaretskii
2019-05-22 19:40 ` Stefan Monnier
2019-05-23 3:50 ` Eli Zaretskii
2019-05-23 4:06 ` Stefan Monnier
2019-05-23 4:52 ` Eli Zaretskii [this message]
2019-05-23 12:10 ` Stefan Monnier
2019-05-23 14:15 ` Eli Zaretskii
2019-05-24 14:22 ` Stefan Monnier
2019-05-24 15:00 ` Eli Zaretskii
2019-05-24 19:31 ` Stefan Monnier
2019-05-24 19:43 ` Eli Zaretskii
2019-05-24 19:51 ` Stefan Monnier
2019-05-25 7:36 ` Eli Zaretskii
2019-05-25 18:38 ` Stefan Monnier
2019-05-25 19:13 ` Eli Zaretskii
2019-05-15 2:41 ` Eli Zaretskii
2019-05-15 6:46 ` Richard Copley
2019-05-15 14:40 ` Eli Zaretskii
2019-05-15 15:12 ` Richard Copley
2019-05-29 18:45 ` Stefan Monnier
2019-05-29 19:11 ` Richard Copley
2019-05-29 20:07 ` Stefan Monnier
2019-05-29 20:50 ` Noam Postavsky
2019-05-30 2:35 ` Eli Zaretskii
2019-05-31 4:54 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838sux7owx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35739@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.