From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 58a3c54: Avoid using string-make-unibyte in select.el Date: Sat, 22 Jun 2019 16:42:27 +0300 Message-ID: <838sttohx8.fsf@gnu.org> References: <20190622083524.20617.42423@vcs0.savannah.gnu.org> <20190622083525.F1CA5209DE@vcs0.savannah.gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110857"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 22 15:42:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hegIB-000SkW-22 for ged-emacs-devel@m.gmane.org; Sat, 22 Jun 2019 15:42:55 +0200 Original-Received: from localhost ([::1]:40864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hegIA-0006AG-2c for ged-emacs-devel@m.gmane.org; Sat, 22 Jun 2019 09:42:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46205) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hegHr-00067H-VJ for emacs-devel@gnu.org; Sat, 22 Jun 2019 09:42:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hegHr-0002a5-Ru; Sat, 22 Jun 2019 09:42:35 -0400 Original-Received: from [176.228.60.248] (port=3658 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hegHq-0005XI-OF; Sat, 22 Jun 2019 09:42:35 -0400 In-reply-to: (message from Stefan Monnier on Sat, 22 Jun 2019 09:26:38 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238037 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Sat, 22 Jun 2019 09:26:38 -0400 > > > + (or (null (multibyte-string-p str)) > > + (setq str (encode-coding-string 'raw-text-unix str)))) > > Isn't this the same as (setq str (string-to-unibyte str))? No, because the former doesn't signal an error. (And I didn't want to use any of those string-to/as-uni/multibyte functions anyway.) The only thing we are supposed to do in the multibyte case is to make sure the raw bytes are converted to their single-byte representation, which is exactly what raw-text-unix does.