From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#37814: [PATCH] Add an option to preserve ANSI sequences
Date: Sat, 19 Oct 2019 09:12:12 +0300
Message-ID: <838sph8ds3.fsf@gnu.org>
References: <20191018181813.21848-1-pablo.barbachano@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="254173"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: 37814@debbugs.gnu.org
To: Pablo =?UTF-8?Q?Barb=C3=A1chano?= <pablo.barbachano@gmail.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 19 08:13:10 2019
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1iLhzB-00141m-AE
	for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 08:13:09 +0200
Original-Received: from localhost ([::1]:49726 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1iLhzA-0003N7-6d
	for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 02:13:08 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58030)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iLhz5-0003N1-3d
 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 02:13:03 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iLhz4-0001aY-7Y
 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 02:13:03 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:42987)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iLhz4-0001aD-4Q
 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 02:13:02 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iLhz3-0005Kj-Tl
 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 02:13:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sat, 19 Oct 2019 06:13:01 +0000
Resent-Message-ID: <handler.37814.B37814.157146555620462@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 37814
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
Original-Received: via spool by 37814-submit@debbugs.gnu.org id=B37814.157146555620462
 (code B ref 37814); Sat, 19 Oct 2019 06:13:01 +0000
Original-Received: (at 37814) by debbugs.gnu.org; 19 Oct 2019 06:12:36 +0000
Original-Received: from localhost ([127.0.0.1]:51807 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1iLhye-0005Jy-H9
 for submit@debbugs.gnu.org; Sat, 19 Oct 2019 02:12:36 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:48942)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@gnu.org>) id 1iLhya-0005Jf-2m
 for 37814@debbugs.gnu.org; Sat, 19 Oct 2019 02:12:33 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60172)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iLhyU-00015K-W7; Sat, 19 Oct 2019 02:12:27 -0400
Original-Received: from [176.228.60.248] (port=3728 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iLhyT-0001Ca-Qp; Sat, 19 Oct 2019 02:12:26 -0400
In-reply-to: <20191018181813.21848-1-pablo.barbachano@gmail.com> (message from
 Pablo =?UTF-8?Q?Barb=C3=A1chano?= on Fri,
 18 Oct 2019 20:18:13 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
 <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:169698
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/169698>

> From: Pablo Barbáchano <pablo.barbachano@gmail.com>
> Date: Fri, 18 Oct 2019 20:18:13 +0200
> Cc: Pablo Barbáchano <pablo.barbachano@gmail.com>
> 
> * lisp/ansi-color.el Add an option to preserve the ANSI sequences
> * test/lisp/ansi-color-tests.el: Add tests

Thank you for your contribution.

Could you please elaborate on the use case(s) that could benefit from
this change?

Also, using overlays would mean that copying the text elsewhere will
reveal the SGR sequences, is that intended?  If not, perhaps using
text properties would be better?

Did you consider using some non-trivial invisibility spec instead of
just t?  It's hard to say if this would make sense without knowing the
use cases you had in mind.

The commit log message is not formatted according to our conventions;
see CONTRIBUTE in the Emacs sources for the details.

Finally, these changes are too large for us to accept them without a
copyright assignment.  Would you like to start the legal paperwork to
that end?  If so, I will send you the form to fill.

Thanks again for your interest in Emacs.