From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master 50c5d56: --with-cairo is no longer
 experimental
Date: Thu, 14 Nov 2019 13:53:45 +0200
Message-ID: <838soi7jxy.fsf@gnu.org>
References: <20190619070851.22726.77187@vcs0.savannah.gnu.org>
 <20190619070853.E841E208EC@vcs0.savannah.gnu.org>
 <m2h83i4np3.fsf@gmail.com> <83imnygoyd.fsf@gnu.org>
 <m2v9ry1407.fsf@gmail.com> <83d0e5he3w.fsf@gnu.org>
 <m2ftj1h2r9.fsf@gmail.com> <837e4dgf30.fsf@gnu.org>
 <m2pni4vzqc.fsf@gmail.com> <838sorg3ll.fsf@gnu.org>
 <m2o8xnekdw.fsf@gmail.com> <83k18beh1b.fsf@gnu.org>
 <m2ftiykpwb.fsf@gmail.com> <83tv7da6qf.fsf@gnu.org> <m21rud1qiq.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="116818"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 12:54:12 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iVDhT-000UBU-Pg
	for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 12:54:11 +0100
Original-Received: from localhost ([::1]:56530 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iVDhS-0006Nk-0E
	for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 06:54:10 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39801)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iVDhL-0006Nc-WE
 for emacs-devel@gnu.org; Thu, 14 Nov 2019 06:54:05 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49025)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iVDhL-00081W-SO; Thu, 14 Nov 2019 06:54:03 -0500
Original-Received: from [176.228.60.248] (port=4276 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iVDhK-0000WH-Vg; Thu, 14 Nov 2019 06:54:03 -0500
In-reply-to: <m21rud1qiq.fsf@gmail.com> (message from Robert Pluim on Tue, 12
 Nov 2019 08:51:25 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:242146
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/242146>

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 12 Nov 2019 08:51:25 +0100
> 
> --- i/src/xfaces.c
> +++ w/src/xfaces.c
> @@ -6770,12 +6770,15 @@ syms_of_xfaces (void)
>                doc: /* List of ignored fonts.
>  Each element is a regular expression that matches names of fonts to
>  ignore.  */);
> -#ifdef HAVE_OTF_KANNADA_BUG
> -  /* https://debbugs.gnu.org/30193  */
> -  Vface_ignored_fonts = list1 (build_string ("Noto Serif Kannada"));
> +#ifdef HAVE_XFT
> +  Vface_ignored_fonts = list1 (build_string ("Noto Color Emoji"));
>  #else
>    Vface_ignored_fonts = Qnil;
>  #endif
> +#ifdef HAVE_OTF_KANNADA_BUG
> +  /* https://debbugs.gnu.org/30193  */
> +  Vface_ignored_fonts = Fcons (build_string ("Noto Serif Kannada"), Vface_ignored_fonts);
> +#endif

LGTM, but please also add a short description of the reason why these
fonts are excluded, so that the readers won't need to look up the full
bug discussion.