From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 3df7d06: Added `comint-password-function' hook Date: Mon, 23 Dec 2019 16:01:49 +0200 Message-ID: <838sn3xhrm.fsf@gnu.org> References: <20191223050615.10479.33674@vcs0.savannah.gnu.org> <20191223050617.2BA89212AC@vcs0.savannah.gnu.org> <87woanjq4n.fsf@gmx.de> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="210845"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael@mauger.com, emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 23 15:02:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ijOHm-000sd8-21 for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2019 15:02:14 +0100 Original-Received: from localhost ([::1]:57268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijOHk-0007yd-8B for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2019 09:02:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39869) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijOHe-0007yV-Vh for emacs-devel@gnu.org; Mon, 23 Dec 2019 09:02:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ijOHe-0007gH-FP; Mon, 23 Dec 2019 09:02:06 -0500 Original-Received: from [176.228.60.248] (port=2481 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ijOHd-0006E6-GH; Mon, 23 Dec 2019 09:02:05 -0500 In-reply-to: <87woanjq4n.fsf@gmx.de> (message from Michael Albinus on Mon, 23 Dec 2019 11:24:56 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243583 Archived-At: > From: Michael Albinus > Date: Mon, 23 Dec 2019 11:24:56 +0100 > Cc: "Michael R. Mauger" > > > +*** Abnormal hook `comint-password-function' has been added. > > +This hook permits a derived mode to supply a password for the > > +underlying command interpreter without prompting the user. For > > +example, in sql-mode, the password for connecting to the database may > > +be stored in the connection wallet and may be passed on the command > > +line to start the SQL interpreter. This is a potential security flaw > > +that could expose user's database passwords on the command line > > +through the use of a process list (Bug#8427). With this hook, it is > > +possible to not pass the password on the command line and wait for the > > +program to prompt for the password. When it does so, the password cam > > +be supplied to the SQL interpreter without involving the user just as > > +if it had been supplied on the command line. > > Shouldn't this be documented in the manual, or at least in the > docstring? It should. > Furthermore, we don't mention bug numbers in etc/NEWS. Right. Patches with corrections are welcome. Thanks.