From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Date: Fri, 31 Jan 2020 16:05:09 +0200 Message-ID: <838slnlo16.fsf@gnu.org> References: <87ziakwifi.fsf@holos> <87val88l0d.fsf@users.sourceforge.net> <20170828031104.GA15524@holos.localdomain> <87shgb89q1.fsf@users.sourceforge.net> <20170830015017.GA28668@holos.localdomain> <87wohasikq.fsf@gmail.com> <20190626140303.quhh4psgvd3aneyr@logos.localdomain> <20200126234731.GA12794@holos.localdomain> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 28257@debbugs.gnu.org, npostavs@gmail.com, npostavs@users.sourceforge.net To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 31 15:06:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixWwI-000Nb3-66 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 15:06:30 +0100 Original-Received: from localhost ([::1]:53528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixWwH-0002Rn-85 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 09:06:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41845) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixWvs-0002Pr-0z for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 09:06:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixWvq-00077K-Vh for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 09:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixWvq-00076k-S6 for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 09:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixWvp-0001Vy-NE for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 09:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28257-submit@debbugs.gnu.org id=B28257.15804795395794 (code B ref 28257); Fri, 31 Jan 2020 14:06:01 +0000 Original-Received: (at 28257) by debbugs.gnu.org; 31 Jan 2020 14:05:39 +0000 Original-Received: from localhost ([127.0.0.1]:36727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixWvT-0001VO-0s for submit@debbugs.gnu.org; Fri, 31 Jan 2020 09:05:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixWvR-0001VA-Lz for 28257@debbugs.gnu.org; Fri, 31 Jan 2020 09:05:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixWvM-0005dT-B5; Fri, 31 Jan 2020 09:05:32 -0500 Original-Received: from [176.228.60.248] (port=4771 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixWvK-0000Bz-4L; Fri, 31 Jan 2020 09:05:30 -0500 In-reply-to: <20200126234731.GA12794@holos.localdomain> (message from Mark Oteiza on Sun, 26 Jan 2020 18:47:31 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175488 Archived-At: > Date: Sun, 26 Jan 2020 18:47:31 -0500 > From: Mark Oteiza > Cc: Lars Ingebrigtsen , 28257@debbugs.gnu.org, > npostavs@users.sourceforge.net > > On 26/06/19 at 10:03am, Mark Oteiza wrote: > > On 24/06/19 at 06:51pm, Noam Postavsky wrote: > > > Lars Ingebrigtsen writes: > > > > > > > Mark Oteiza writes: > > > > > > > >>> Could be a worthwhile tradeoff (especially > > > >>>since there currently aren't any individual mode eldoc functions using > > > >>>anything apart from :before-until, afaik); I'm on the fence about this. > > > >> > > > >> Not in emacs, at least. In elpa, ggtags uses :after-until. The only > > > >> 3rd party packages--that I can think of right now--that implement eldoc > > > >> functions just use setq-local (elpy and geiser). > > > > > > > > Noam, still on the fence? > > > > > > I haven't really thought about this much, maybe bring it up on > > > emacs-devel? > > > > I happily rolled with this patch until some changes to eldoc broke it. > > Will post a new patch when I get around to it. > > New patch below. Lightly tested, at first sight it seems to work > (setting eldoc-documentation-function to eldoc-documentation-compose) Lars, Noam, any comments?