From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Wed, 05 Feb 2020 16:20:47 +0200 Message-ID: <838slhglog.fsf@gnu.org> References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="88675"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca, waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 05 15:23:29 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1izLaR-000Myq-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Feb 2020 15:23:27 +0100 Original-Received: from localhost ([::1]:48056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izLaQ-0002vY-EN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Feb 2020 09:23:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49136) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izLZ5-0000Yz-KG for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:22:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izLZ4-0007MY-EK for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:22:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izLZ4-0007Ku-A9 for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1izLZ4-0002gD-6z for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 14:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158091247810250 (code B ref 38992); Wed, 05 Feb 2020 14:22:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 14:21:18 +0000 Original-Received: from localhost ([127.0.0.1]:45241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLYL-0002fF-MB for submit@debbugs.gnu.org; Wed, 05 Feb 2020 09:21:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLYH-0002ey-B4 for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 09:21:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izLYA-0002B0-S2; Wed, 05 Feb 2020 09:21:06 -0500 Original-Received: from [176.228.60.248] (port=4387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1izLY1-000471-A1; Wed, 05 Feb 2020 09:21:06 -0500 In-reply-to: (message from Dmitry Gutov on Wed, 5 Feb 2020 02:57:18 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175694 Archived-At: > Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca, > waah@yellowfrog.io > From: Dmitry Gutov > Date: Wed, 5 Feb 2020 02:57:18 +0300 > > On 01.02.2020 11:07, Eli Zaretskii wrote: > > The second one is fine with me, but why do we need the first one? It > > changes the semantics of a widely used variable. > > The short of it, the second wouldn't work without the first one. Pity. > And the first one makes a lot of sense (no need to invent an extra > variable if the way to store the necessary info is so obvious). I didn't say it didn't make sense. The only issue that worries me is how safe it is for the release branch. I have no issues whatsoever with making these changes on master. > There is some possibility of this causing a regression, but the changes > are relatively small. And no third-party code should be affected by this > change. Are you sure about third-party code? I'm worried by exactly the same assumptions as those which required you to do, e.g., the likes of this: diff --git a/lisp/icomplete.el b/lisp/icomplete.el index a1a67e2330..52429fdf37 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -541,7 +541,7 @@ icomplete-exhibit (icomplete--completion-table) (icomplete--completion-predicate) (if (window-minibuffer-p) - (not minibuffer-completion-confirm))))) + (eq minibuffer-completion-confirm t))))) (buffer-undo-list t) deactivate-mark) ;; Do nothing if while-no-input was aborted. IOW, some code which just assumes that anything non-nil and non-confirm must be confirm-after-completion, or the other way around. It's an incompatible change. Is the problem this attempts to fix really serious? Or is it just a minor inconvenience? It isn't the original one that started the bug report, right?