all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip K <philip@warpmail.net>
Cc: 39376-done@debbugs.gnu.org
Subject: bug#39376: [PATCH] Throw error when calling reverse-region on a single line
Date: Sat, 15 Feb 2020 10:51:54 +0200	[thread overview]
Message-ID: <838sl4nsgl.fsf@gnu.org> (raw)
In-Reply-To: <20200131212624.4658-1-philip@warpmail.net> (message from Philip K on Fri, 31 Jan 2020 22:26:24 +0100)

> From: Philip K <philip@warpmail.net>
> Date: Fri, 31 Jan 2020 22:26:24 +0100
> 
> The current implementation of reverse region will delete everything
> following the current line, if the region marks only a part of a
> line. This is because the algorithm implemented below accidentally
> deletes all following lines, and fails before being able to reinsert
> them.
> 
> This patch sends an error (could be changed to an user-error) in that
> case, as it makes no sense for a single line to be reversed.

Thanks.  I installed a slightly different change, because the command
would still delete the following lines if only BEG or END (bit not
both) was not at a line beginning/end.

I also fixed the doc string and the comments there.





      reply	other threads:[~2020-02-15  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 21:26 bug#39376: [PATCH] Throw error when calling reverse-region on a single line Philip K
2020-02-15  8:51 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838sl4nsgl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39376-done@debbugs.gnu.org \
    --cc=philip@warpmail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.