From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions Date: Thu, 05 Mar 2020 21:31:20 +0200 Message-ID: <838skevbsn.fsf@gnu.org> References: <87mwaq74xg.fsf@fencepost.gnu.org> <87h7z86hs9.fsf@stefankangas.se> <86v9nooxcg.fsf@gmail.com> <87tv38kp33.fsf@fencepost.gnu.org> <83sgisypbd.fsf@gnu.org> <87pndwklz6.fsf@fencepost.gnu.org> <83o8tgyn1k.fsf@gnu.org> <874kv83pg7.fsf@fencepost.gnu.org> <83lfokylpp.fsf@gnu.org> <87r1yb8kbv.fsf@gmail.com> <87wo8340ct.fsf@stefankangas.se> <874kv7ozf9.fsf@fencepost.gnu.org> <87o8tf7xu3.fsf@gmail.com> <83mu8yyawu.fsf@gnu.org> <874kv299f7.fsf@gmail.com> <87pndqet7k.fsf@fencepost.gnu.org> <8536amk7q6.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="31269"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 20:32:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9wE8-00082b-Pv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 20:32:12 +0100 Original-Received: from localhost ([::1]:55298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9wE7-0004oK-RR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 14:32:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34920) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9wDz-0004lL-Ui for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 14:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9wDy-000174-W2 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 14:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9wDy-00016u-SV for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 14:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9wDy-000471-9y for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18336 X-GNU-PR-Package: emacs Original-Received: via spool by 18336-submit@debbugs.gnu.org id=B18336.158343670915787 (code B ref 18336); Thu, 05 Mar 2020 19:32:02 +0000 Original-Received: (at 18336) by debbugs.gnu.org; 5 Mar 2020 19:31:49 +0000 Original-Received: from localhost ([127.0.0.1]:43743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9wDk-00046Z-O5 for submit@debbugs.gnu.org; Thu, 05 Mar 2020 14:31:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9wDi-00046N-Io for 18336@debbugs.gnu.org; Thu, 05 Mar 2020 14:31:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j9wDd-0000x2-5Q; Thu, 05 Mar 2020 14:31:41 -0500 Original-Received: from [176.228.60.248] (port=1539 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j9wDZ-00010Q-SD; Thu, 05 Mar 2020 14:31:38 -0500 In-Reply-To: <8536amk7q6.fsf@gmail.com> (message from Noam Postavsky on Thu, 05 Mar 2020 12:54:41 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176932 Archived-At: > From: Noam Postavsky > Cc: Eli Zaretskii , stefan@marxist.se, 18336@debbugs.gnu.org > Date: Thu, 05 Mar 2020 12:54:41 -0500 > > > Thanks. Any suggestions for how to fix this? A new argument to > > lock_file, perhaps? Or maybe some additional check in > > userlock--ask-user-about-supersession-threat to recognize the special > > situation where we are saving a file? > > I'm not sure. Why exactly are we calling lock_file from write_region? Because write-region can be called from an unmodified buffer, I suppose, and from a buffer whose buffer-file-name is not the same as the file being written to. > Do not (normally) call this for a buffer already modified, > as either the file is already locked, or the user has already > decided to go ahead without locking. > > It seems we are doing exactly this, so I guess that makes > save-buffer/write-region an "abnormal" situation? Evidently, when we disabled backups in /tmp, we missed the fact that lock_file called from write-region will be affected. When backups are not disabled, this works correctly.