From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: GDI+ take 3
Date: Sat, 18 Apr 2020 13:00:50 +0300
Message-ID: <838sitazal.fsf@gnu.org>
References: <86h7xzc5ai.fsf@csic.es> <83d08mt7gy.fsf@gnu.org>
 <83eesrkivc.fsf@gnu.org> <865ze3wvk8.fsf@csic.es> <837dyihyjc.fsf@gnu.org>
 <877dyh28ci.fsf@tcd.ie> <83o8rthnvr.fsf@gnu.org> <87zhbdwx1c.fsf@tcd.ie>
 <83mu7dgtls.fsf@gnu.org>
 <CAAeL0SSviVBNHtY7CMYRgnBekHCFyu4ijT6zJ2_qTwj6NPc0Gg@mail.gmail.com>
 <83a73chmrl.fsf@gnu.org>
 <CAAeL0SRHqe5Q6WPTrC2fS77HCpBHc0UYg4GMpvD4on+SPUoSOw@mail.gmail.com>
 <CAAeL0STWcPV_LwsPa8BbTfeMRbX5E-d5a8JqqzgFYrhZUoFr8Q@mail.gmail.com>
 <831roohlgw.fsf@gnu.org>
 <CAAeL0SSR_JyLfBaVi8APYJ8nUdfQjrLgWGgR=fN_Mj6iCzHxeg@mail.gmail.com>
 <83y2qwg673.fsf@gnu.org>
 <CAAeL0SR3rXn1QgAOyFTD86xKNh36QcoWzgWvQKNN8bnStLUghA@mail.gmail.com>
 <CAAeL0STCB4k-CVOnKeOmRi1Xbb4S40EhLdShyVAeBgi-dhJ6nw@mail.gmail.com>
 <83v9m0g4yw.fsf@gnu.org>
 <CAAeL0STzbAAo7wiPAqd5fikNpSU+i+RWae-UX5KB92JcQs+Y9A@mail.gmail.com>
 <83sgh4g3af.fsf@gnu.org>
 <CAAeL0STMjZnprTiu2-rKn9p=hsHJU2-7M2q7FsjH1yhQqSEETQ@mail.gmail.com>
 <83k12gfzxc.fsf@gnu.org>
 <CAAeL0STE_SsW58EcP2UPSJYy=84RswqKwo3v504H8Msvm-of_Q@mail.gmail.com>
 <83eesofyac.fsf@gnu.org>
 <CAAeL0SR5heGT66kRn-FEANS4vyVg_hVefAn2o3T3227LBdnFFg@mail.gmail.com>
 <83d088fwgt.fsf@gnu.org>
 <CAAeL0ST+S=4Bn_1QV7rncU5Gy0LAeG5vycAsOxBCdnSfCo+e6g@mail.gmail.com>
 <835ze0fqk2.fsf@gnu.org>
 <CAAeL0SSxeSsq2Ag4_t_671y24+N-SpRMyE1x94qtghiXrMiMcw@mail.gmail.com>
 <83sgh3eogs.fsf@gnu.org>
 <CAAeL0SR0D5HgaECRo7seAKe+U_4i20NrDfpjW=M+Csb7i=qYgg@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="52439"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: juanjose.garciaripoll@gmail.com, emacs-devel@gnu.org
To: Juanma Barranquero <lekktu@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 18 12:01:44 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jPkIC-000DY7-2l
	for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Apr 2020 12:01:44 +0200
Original-Received: from localhost ([::1]:56398 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jPkIB-0003yS-5g
	for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Apr 2020 06:01:43 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37115)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1jPkHX-00034c-2V
 for emacs-devel@gnu.org; Sat, 18 Apr 2020 06:01:04 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56436)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1jPkHV-0002w2-TW; Sat, 18 Apr 2020 06:01:02 -0400
Original-Received: from [176.228.60.248] (port=3720 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jPkHT-0004Ss-To; Sat, 18 Apr 2020 06:01:00 -0400
In-Reply-To: <CAAeL0SR0D5HgaECRo7seAKe+U_4i20NrDfpjW=M+Csb7i=qYgg@mail.gmail.com>
 (message from Juanma Barranquero on Fri, 17 Apr 2020 01:49:46 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:247219
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/247219>

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Fri, 17 Apr 2020 01:49:46 +0200
> Cc: juanjose.garciaripoll@gmail.com, Emacs developers <emacs-devel@gnu.org>
> 
> On Thu, Apr 16, 2020 at 12:04 PM Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > In addition, multi-page TIFF files I tried (from
> > https://www.nightprogrammer.org/development/multipage-tiff-example-download-test-image-file/)
> > fail to load: GdipCreateBitmapFromFile returns status = InvalidParameter,
> > for no clear reason.  Single-page TIFF images do load successfully.
> 
> These two images crash my emacs with w32-use-native-image-API = t. Single page tifs work as expected.

Thanks, I hope with Juan's latest change this is prevented.  In any
case, I replaced the emacs_abort call with returning a negative value,
which should avoid using the invalid data and add a log message.