From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Tue, 18 Aug 2020 17:51:41 +0300 Message-ID: <838secf1mq.fsf@gnu.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> <83o8pyc4bq.fsf@gnu.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> <83img48ffx.fsf@gnu.org> <83bllw82xt.fsf@gnu.org> <1B0F31C8-1E11-4527-A053-DD2DE8235F58@acm.org> <83wo4g5hz6.fsf@gnu.org> <49B7D7B5-D9E3-4E97-A749-CF5E8D8EE2C6@acm.org> <83mu5b5573.fsf@gnu.org> <83lfku69q2.fsf@gnu.org> <87eeo4m5kd.fsf@gnus.org> <83d03of3pf.fsf@gnu.org> <87blj8kpsr.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34949"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, mattiase@acm.org, tom@tromey.com, 41544@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 18 17:31:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k83a5-0008zi-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 17:31:21 +0200 Original-Received: from localhost ([::1]:40730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k83a4-0000nw-By for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Aug 2020 11:31:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k82z0-0004w3-BM for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 10:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k82z0-0004fj-29 for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 10:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k82z0-0005Gw-10 for bug-gnu-emacs@gnu.org; Tue, 18 Aug 2020 10:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Aug 2020 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159776232620187 (code B ref 41544); Tue, 18 Aug 2020 14:53:01 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 18 Aug 2020 14:52:06 +0000 Original-Received: from localhost ([127.0.0.1]:36641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k82y1-0005FT-W9 for submit@debbugs.gnu.org; Tue, 18 Aug 2020 10:52:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k82y0-0005Ex-8j for 41544@debbugs.gnu.org; Tue, 18 Aug 2020 10:52:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53184) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k82xt-0004Z1-QS; Tue, 18 Aug 2020 10:51:53 -0400 Original-Received: from [176.228.60.248] (port=1236 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k82xt-0002pq-8e; Tue, 18 Aug 2020 10:51:53 -0400 In-Reply-To: <87blj8kpsr.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 18 Aug 2020 16:10:44 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185497 Archived-At: > From: Lars Ingebrigtsen > Cc: mattiase@acm.org, simenheg@runbox.com, tom@tromey.com, > 41544@debbugs.gnu.org > Date: Tue, 18 Aug 2020 16:10:44 +0200 > > Eli Zaretskii writes: > > > How do they make things better, and what things, exactly? My > > recollection is that this was about consistency, not correctness. > > According to the screen shots, they compute correct colours (based on > fixing the luminance formulas, if I remember correctly (it's been a > couple weeks since I read this thread)). My bitter experience with handling colors in Emacs is that changes frequently fix some use cases and botch others. So I'd prefer to make such changes only where the current results are completely unacceptable (and I'd be surprised if we have such cases nowadays). > > I don't think defcustom is the proper way of handling differences in > > behavior at this low level. > > Different ways of computing colours? That's not very low level. I think it is. Think about what you'd say in the doc string of such a defcustom. "If non-nil, handle colors correctly, otherwise handle them incorrectly"?