From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 27.1 Windows Binaries -- testing wanted Date: Sat, 22 Aug 2020 18:19:11 +0300 Message-ID: <838se6aets.fsf@gnu.org> References: <83pn7oft7r.fsf@gnu.org> <5fd1bc533b4bfe603d106fb3ee816208@russet.org.uk> <83364keznu.fsf@gnu.org> <87imdgrlpq.fsf@telefonica.net> <83tuwzewxa.fsf@gnu.org> <87eeo3sxw0.fsf@telefonica.net> <47436f6137c965db141e290de6597fd5@russet.org.uk> <464a5bf221d1d77ea13381fb901931fd@russet.org.uk> <25cec7cf-804f-4777-9f88-295f1735e6c5_IMAP_ADDED_MISSING@UPANOVA> <4a785b99c43d27a7e7d7a231db6c8f06@russet.org.uk> <83wo1r9oen.fsf@gnu.org> <83ft8f9d5o.fsf@gnu.org> <83eenz9bir.fsf@gnu.org> <8373b3870aaea52590ee392bd6ff1ca9@russet.org.uk> <83blj2akvl.fsf@gnu.org> <21e339147a2817352781e4abcc342bfb@russet.org.uk> <83a6ymagux.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 22 17:19:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9VJA-0004HK-KB for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Aug 2020 17:19:52 +0200 Original-Received: from localhost ([::1]:39812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9VJ9-0002JW-NH for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Aug 2020 11:19:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9VIe-0001sw-Cu for emacs-devel@gnu.org; Sat, 22 Aug 2020 11:19:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38899) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9VIe-0001FN-3z; Sat, 22 Aug 2020 11:19:20 -0400 Original-Received: from [176.228.60.248] (port=3078 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k9VId-00077z-KN; Sat, 22 Aug 2020 11:19:19 -0400 In-Reply-To: (phillip.lord@russet.org.uk) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254124 Archived-At: > Date: Sat, 22 Aug 2020 16:13:52 +0100 > From: phillip.lord@russet.org.uk > Cc: emacs-devel@gnu.org > > > Skipping a test and failing a test is not the same. You are looking > > for failures: tests that should have succeeded, but didn't. > > Indeed not. But, skipping a test because something is not compiled in is > wrong iff the feature is supposed to be compiled in. Running "make > check" on my windows build machine will only pick up errors with json > parsing if libjansson was installed. That's a separate problem. If you want to be able to detect it as well, you'd probably need a separate test for features that appear in system-configuration-features. > I still think that the windows binary distribution is unnecessarily > complicated, based on the msys2 dependencies as given. I agree, but if you want to depend on MSYS2 dependency tracking, that's part of the price, no?