From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file Date: Mon, 19 Oct 2020 19:40:08 +0300 Message-ID: <838sc2p3tj.fsf@gnu.org> References: <197409406.192953.1598809591346@ichabod.co-bxl> <9aa79095-18d6-d0bd-18ad-aa5d90f0bb1d@yandex.ru> <1898378843.430816.1599957743795@ichabod.co-bxl> <83bli9db3t.fsf@gnu.org> <1670898213.459425.1600016799389@ichabod.co-bxl> <83h7s1bmy5.fsf@gnu.org> <87363lh856.fsf@gnus.org> <1357196034.463572.1600022946152@ichabod.co-bxl> <83k0vnqwpg.fsf@gnu.org> <83d01fqusy.fsf@gnu.org> <838sc3qsvf.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9239"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 43117@debbugs.gnu.org, rpluim@gmail.com, leungbk@mailfence.com, dgutov@yandex.ru To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 19 18:41:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUYDk-0002JC-F9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 18:41:16 +0200 Original-Received: from localhost ([::1]:50054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUYDj-0006Ct-9W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 12:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUYDW-0006BT-11 for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 12:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUYDV-0006uT-Nc for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 12:41:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUYDV-0006hj-Kf for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 12:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2020 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43117-submit@debbugs.gnu.org id=B43117.160312561525712 (code B ref 43117); Mon, 19 Oct 2020 16:41:01 +0000 Original-Received: (at 43117) by debbugs.gnu.org; 19 Oct 2020 16:40:15 +0000 Original-Received: from localhost ([127.0.0.1]:42185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUYCg-0006gV-KP for submit@debbugs.gnu.org; Mon, 19 Oct 2020 12:40:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUYCf-0006gG-Fi for 43117@debbugs.gnu.org; Mon, 19 Oct 2020 12:40:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37551) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUYCZ-0006WP-6a; Mon, 19 Oct 2020 12:40:03 -0400 Original-Received: from [176.228.60.248] (port=4432 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUYCY-0008Eh-FY; Mon, 19 Oct 2020 12:40:03 -0400 In-Reply-To: (message from Stefan Kangas on Mon, 19 Oct 2020 16:06:45 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191014 Archived-At: > From: Stefan Kangas > Date: Mon, 19 Oct 2020 16:06:45 +0000 > Cc: leungbk@mailfence.com, larsi@gnus.org, rpluim@gmail.com, > 43117@debbugs.gnu.org, dgutov@yandex.ru > > Eli Zaretskii writes: > > > Why would someone want to skip commits in "git blame"? We need to > > have agreed-upon criteria or policy for that, otherwise each one of > > use will step on the others' toes. "git blame" is an important > > forensics command, so hiding commits from it might surprise someone, > > if it's unexpected. > > For example, if a commit fixed a typo in a doc string, I'd much rather > see the commit that added that text than the one that fixed the typo. But that's your personal preference, isn't it? Do we know for sure no one will ever want to see changes that fixed typos? For example, what about some "typo" that is controversial (like the "parseable" thing we discussed lately), and we want to know who and why "fixed" it? In short, the more I think about this feature, the less it makes sense to me to use it in our project. It's probably fine for a single-developer projects, where the preferences are never in conflict. But ours is a very different project. > >> Wouldn't having non-existent commit ids in there mostly be an aesthetic > >> problem? > > > > I don't know. Will it? I have no experience with this feature. > > AFAIU, git will just skip over non-existent commits in this case. It requires a setting in .git/config, doesn't it? Would older versions of Git warn about the setting they don't know about? Or do we expect users to turn this on in their ~/.gitconfig instead?