From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: face-attribute and face-remapping-alist
Date: Wed, 31 Mar 2021 16:27:10 +0300 [thread overview]
Message-ID: <838s63ihch.fsf@gnu.org> (raw)
In-Reply-To: <aeaecad1-c5c0-c31b-66ec-c19bcf0d5941@gmail.com> (message from Clément Pit-Claudel on Wed, 31 Mar 2021 09:00:34 -0400)
> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Wed, 31 Mar 2021 09:00:34 -0400
>
> On 3/31/21 2:58 AM, Eli Zaretskii wrote:
> > Sure, but the only change needed in all the cases you described in
> > order to return attributes that are aware of the remapping is to look
> > up the face in face-remapping-alist, before calling face-attribute.
>
> You need to look it up recursively, which adds to the complexity. And it's more complicated than that if you use the "inherit" argument, since you need to check whether the default face is remapped as well, and merge that with the real default face.
The issue described by the OP was of accessing the attribute's value,
not merging face attributes.
Merging faces is a separate issue. It is rare that an application
should need to merge faces, as Emacs does that automatically.
next prev parent reply other threads:[~2021-03-31 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 18:53 face-attribute and face-remapping-alist gliao.tw
2021-03-30 19:05 ` Eli Zaretskii
2021-03-30 19:13 ` Eli Zaretskii
2021-03-31 3:05 ` gliao.tw
2021-03-31 3:34 ` gliao.tw
2021-03-31 6:58 ` Eli Zaretskii
2021-03-31 13:00 ` Clément Pit-Claudel
2021-03-31 13:27 ` Eli Zaretskii [this message]
2021-03-31 22:41 ` gliao.tw
2021-04-01 7:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838s63ihch.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.