From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression Date: Mon, 19 Apr 2021 20:15:15 +0300 Message-ID: <838s5eryak.fsf@gnu.org> References: <835z0kulkq.fsf@gnu.org> <83blabtqqz.fsf@gnu.org> <83wnsys9ml.fsf@gnu.org> <83k0oys52v.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5475"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47860@debbugs.gnu.org, gregory@heytings.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 19 19:17:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYXWT-0001GR-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 19:17:21 +0200 Original-Received: from localhost ([::1]:51338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYXWS-00036d-QH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Apr 2021 13:17:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYXVH-0001bw-Eo for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 13:16:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYXVB-0000rc-O8 for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 13:16:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYXVB-00064Y-Jp for bug-gnu-emacs@gnu.org; Mon, 19 Apr 2021 13:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Apr 2021 17:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47860 X-GNU-PR-Package: emacs Original-Received: via spool by 47860-submit@debbugs.gnu.org id=B47860.161885254923322 (code B ref 47860); Mon, 19 Apr 2021 17:16:01 +0000 Original-Received: (at 47860) by debbugs.gnu.org; 19 Apr 2021 17:15:49 +0000 Original-Received: from localhost ([127.0.0.1]:51912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXUv-000642-8L for submit@debbugs.gnu.org; Mon, 19 Apr 2021 13:15:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYXUq-00063m-Kh for 47860@debbugs.gnu.org; Mon, 19 Apr 2021 13:15:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45647) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYXUl-0000fo-B3; Mon, 19 Apr 2021 13:15:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1913 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lYXUi-0005n9-9r; Mon, 19 Apr 2021 13:15:34 -0400 In-Reply-To: (message from Aaron Jensen on Mon, 19 Apr 2021 11:19:06 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204490 Archived-At: > From: Aaron Jensen > Date: Mon, 19 Apr 2021 11:19:06 -0500 > Cc: Gregory Heytings , 47860@debbugs.gnu.org > > Okay, here's a selectrum-free repro that, on emacs 27 shows all 3 > lines and on emacs 28 shows only two lines: > > (defun foo--set-window-height (window &optional height) > (let ((dheight (or height (cdr (window-text-pixel-size window)))) > (wheight (window-pixel-height window)) > (window-resize-pixelwise t)) > (window-resize > window (- dheight wheight) nil nil 'pixelwise))) Yes, that's the problem: selectrum doesn't rely on the automatic mini-window resize, it resizes the mini-window manually! And it relies on window-text-pixel-size to tell how high should the mini-window become. So the root cause is in window-text-pixel-size when this crazy mix of overlays is used. Will take a look when I have time.