From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2ed2999: Improve documentation of new Xref options Date: Tue, 07 Sep 2021 18:47:31 +0300 Message-ID: <838s08peuk.fsf@gnu.org> References: <20210905075953.20536.20920@vcs0.savannah.gnu.org> <20210905075955.0F6B720A0A@vcs0.savannah.gnu.org> <6f1fcbee-1825-1219-88fb-e6f28d00ab4d@yandex.ru> <831r62tjf3.fsf@gnu.org> <0eaa7dc7-a3f2-5319-bf09-629f9949e416@yandex.ru> <834kaxsxb8.fsf@gnu.org> <7fe2eafb-e15a-beab-f485-9c80b2913121@yandex.ru> <831r61soqu.fsf@gnu.org> <6c33d3c8-5155-f0fe-ec47-0630d9f3525f@yandex.ru> <83h7ewpmc4.fsf@gnu.org> <6b688b48-eae7-1dbc-3de6-97f071583659@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15003"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 07 17:50:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNdMF-0003cd-7z for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 17:49:59 +0200 Original-Received: from localhost ([::1]:52076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNdMD-0005Za-88 for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 11:49:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNdJh-0001HY-PZ for emacs-devel@gnu.org; Tue, 07 Sep 2021 11:47:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54420) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNdJh-0007zw-Fk; Tue, 07 Sep 2021 11:47:21 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4254 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNdJh-0000uX-2u; Tue, 07 Sep 2021 11:47:21 -0400 In-Reply-To: <6b688b48-eae7-1dbc-3de6-97f071583659@yandex.ru> (message from Dmitry Gutov on Tue, 7 Sep 2021 18:24:46 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274256 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Tue, 7 Sep 2021 18:24:46 +0300 > > On 07.09.2021 16:05, Eli Zaretskii wrote: > > >> Or "commands which display many matches, with high likelihood that the > >> user will want to visit every match, rather than just pick one". At > >> least that was the thinking behind xref-show-definitions-function vs > >> xref-show-xrefs-function. > > > > OK, I hope I fixed this stuff now, please take a look. > > Thank you, sent some comments. > > You didn't seem to adopt the suggested description, but OK. Which ones? > > Should we perhaps treat dired-do-find-regexp like we do with > > dired-do-find-regexp-and-replace, to avoid confusion due to > > inconsistency? > > dired-do-find-regexp-and-replace is a totally different command, which > could use an entirely different UI (as soon as someone wrote one). > > There is no way to have it obey xref-auto-jump-to-first-xref: it simply > failed to work without the fix. I understand. But wouldn't it confuse users that dired-do-find-regexp obeys the option, while dired-do-find-regexp-and-replace does not? I though perhaps we should make both not obey.