From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51296: [PATCH] Add WebP format support Date: Thu, 21 Oct 2021 21:39:55 +0300 Message-ID: <838rym8bno.fsf@gnu.org> References: <837de7bzy0.fsf@gnu.org> <83y26nac3e.fsf@gnu.org> <8335ouaixr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37233"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51296@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 20:42:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdd1c-0009VQ-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 20:42:48 +0200 Original-Received: from localhost ([::1]:54766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdd1b-0007qC-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 14:42:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdczw-0005Yg-2W for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 14:41:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdczu-0005fW-KD for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 14:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdczu-0003HT-If for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51296-submit@debbugs.gnu.org id=B51296.163484160812520 (code B ref 51296); Thu, 21 Oct 2021 18:41:02 +0000 Original-Received: (at 51296) by debbugs.gnu.org; 21 Oct 2021 18:40:08 +0000 Original-Received: from localhost ([127.0.0.1]:58552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdcz1-0003Fr-Rq for submit@debbugs.gnu.org; Thu, 21 Oct 2021 14:40:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdcyz-0003FD-Kf for 51296@debbugs.gnu.org; Thu, 21 Oct 2021 14:40:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59564) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdcyu-0001kr-A9; Thu, 21 Oct 2021 14:40:00 -0400 Original-Received: from [87.69.77.57] (port=3574 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdcyt-0001Q4-TI; Thu, 21 Oct 2021 14:40:00 -0400 In-Reply-To: (message from Stefan Kangas on Thu, 21 Oct 2021 11:36:45 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217801 Archived-At: > From: Stefan Kangas > Date: Thu, 21 Oct 2021 11:36:45 -0700 > Cc: 51296@debbugs.gnu.org > > >> + contents = (uint8_t*) SSDATA (specified_data); > > > > Space before '*' again. Also, is the type cast really needed? If > > not, it is better to drop it. > > Fixed the style issue. > > The cast fixes this warning, so I kept it and added a comment saying > "Casting avoids a GCC warning": > > image.c: In function ‘webp_load’: > image.c:8878:16: warning: pointer targets in assignment from ‘char *’ > to ‘uint8_t *’ {aka ‘unsigned char *’} differ in signedness > [-Wpointer-sign] > 8878 | contents = SSDATA (specified_data); > | ^ And if you use SDATA instead of SSDATA? Otherwise, I think this is good to go, thanks.