From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 51296@debbugs.gnu.org
Subject: bug#51296: [PATCH] Add WebP format support
Date: Thu, 21 Oct 2021 21:39:55 +0300 [thread overview]
Message-ID: <838rym8bno.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmk8Dxzv2nmFcx9n-w1bSsvio85+g6b12SpuoXOz+oihPw@mail.gmail.com> (message from Stefan Kangas on Thu, 21 Oct 2021 11:36:45 -0700)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 21 Oct 2021 11:36:45 -0700
> Cc: 51296@debbugs.gnu.org
>
> >> + contents = (uint8_t*) SSDATA (specified_data);
> >
> > Space before '*' again. Also, is the type cast really needed? If
> > not, it is better to drop it.
>
> Fixed the style issue.
>
> The cast fixes this warning, so I kept it and added a comment saying
> "Casting avoids a GCC warning":
>
> image.c: In function ‘webp_load’:
> image.c:8878:16: warning: pointer targets in assignment from ‘char *’
> to ‘uint8_t *’ {aka ‘unsigned char *’} differ in signedness
> [-Wpointer-sign]
> 8878 | contents = SSDATA (specified_data);
> | ^
And if you use SDATA instead of SSDATA?
Otherwise, I think this is good to go, thanks.
next prev parent reply other threads:[~2021-10-21 18:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 23:27 bug#51296: [PATCH] Add WebP format support Stefan Kangas
2021-10-20 8:42 ` Lars Ingebrigtsen
2021-10-20 12:40 ` Stefan Kangas
2021-10-20 13:02 ` Stefan Kangas
2021-10-20 13:14 ` Eli Zaretskii
2021-10-20 15:22 ` Stefan Kangas
2021-10-20 16:35 ` Eli Zaretskii
2021-10-20 17:13 ` Eli Zaretskii
2021-10-20 17:41 ` Stefan Kangas
2021-10-20 18:19 ` Eli Zaretskii
2021-10-20 21:02 ` Stefan Kangas
2021-10-21 0:45 ` Stefan Kangas
2021-10-21 8:19 ` Eli Zaretskii
2021-10-21 18:36 ` Stefan Kangas
2021-10-21 18:39 ` Eli Zaretskii [this message]
2021-10-21 21:19 ` Stefan Kangas
2021-10-22 6:16 ` Eli Zaretskii
2021-10-22 9:03 ` Stefan Kangas
2021-10-22 12:06 ` Eli Zaretskii
2021-10-22 12:47 ` Eli Zaretskii
2021-10-22 14:27 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rym8bno.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51296@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.