From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57152: 29.0.50; Emacs executable isn't rebuilt when loaddefs.el is modified Date: Mon, 15 Aug 2022 14:58:07 +0300 Message-ID: <838rnpiur4.fsf@gnu.org> References: <83k07endtb.fsf@gnu.org> <87zgg9o5nx.fsf@gnus.org> <8335e1o4yg.fsf@gnu.org> <878rnsl683.fsf@gnus.org> <87a685akh8.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57152@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 13:59:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNYl0-0005HY-Kj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 13:59:46 +0200 Original-Received: from localhost ([::1]:59468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNYkz-0002tP-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 07:59:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNYkI-0002PW-D9 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 07:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNYkI-0003yJ-3d for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 07:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNYkI-0007Ef-0G for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 07:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 11:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57152 X-GNU-PR-Package: emacs Original-Received: via spool by 57152-submit@debbugs.gnu.org id=B57152.166056471327779 (code B ref 57152); Mon, 15 Aug 2022 11:59:01 +0000 Original-Received: (at 57152) by debbugs.gnu.org; 15 Aug 2022 11:58:33 +0000 Original-Received: from localhost ([127.0.0.1]:41089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNYjp-0007Dy-3w for submit@debbugs.gnu.org; Mon, 15 Aug 2022 07:58:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNYjj-0007Dh-Gc for 57152@debbugs.gnu.org; Mon, 15 Aug 2022 07:58:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNYje-0003w3-1G; Mon, 15 Aug 2022 07:58:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IC22e+19NYGOe7v4moK/9G33CnsV6icAMqZsReGgM7s=; b=eVKPFEA1y+C0 q19G7OQBVh+cWUAU1H/u1AQBPmyK1s1Ke7H7n3+iWKTzs5kYv5bp3TRZwtD69UpyJ3KGWafpnsTkD A05P4dc+KGdlsFVb3VuvagrbTHK1Kia9/YjHSveAdBWdT18LOkYFiw0Kehbcz/AQK5JYraYyjCTPY mpTr2A7eMMh21s8I6+IGAk24LYJWJlqLHfBE8o/nJOc585MFIVnhYKtdJ5t3IbO0QPM2kAbDotNe8 JWD8pmB2Gp+YskMn/Ge+QyU8bTVRewj41e28r881et5nOtQ9/vzWywBEbR5SOSoFSkdRUDGfhxXFT vgPfWw3mvjukskT92DSCFQ==; Original-Received: from [87.69.77.57] (port=4694 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNYjd-0002HH-C9; Mon, 15 Aug 2022 07:58:21 -0400 In-Reply-To: <87a685akh8.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 15 Aug 2022 12:07:15 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239784 Archived-At: > From: Lars Ingebrigtsen > Cc: 57152@debbugs.gnu.org > Date: Mon, 15 Aug 2022 12:07:15 +0200 > > I've tried various things, like making autoloads an order-only > prerequisite for $(pdmp) (and various other targets), but the main > problem seems to be that Make has already computed the > timestamps/dependencies at this point, so even if we're running the > update at the "right" time, we don't trigger the $(pdmp) rule. That cannot be the reason, AFAIK. Make begins by reading all the rules and dependencies in the Makefile and producing a DAG for rebuilding the targets; then it walks the DAG invoking commands as it goes. Thus, a target that is going to be rebuilt will automatically trigger the rules of all the targets that depend on it, as long as the dependencies are known to Make in full. IOW, Make doesn't update the timestamps of files during the build, it figures it all out in advance. So I think the problem here is that the rules which trigger regeneration of loaddefs.el are in lisp/Makefile, while the rules for building $(pdmp) are in src/Makefile. So maybe moving or duplicating the loaddefs.el rules in src/Makefile will do the trick.