From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Date: Thu, 08 Sep 2022 12:20:13 +0300 Message-ID: <838rmufcj6.fsf@gnu.org> References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> <87sfl26ypw.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4678"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 55039@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 08 11:22:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWDk2-00013g-9q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 11:22:34 +0200 Original-Received: from localhost ([::1]:53086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWDk1-0002XX-Cd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 05:22:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDia-0007Xw-Ag for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 05:21:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWDiY-00012N-ET for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 05:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWDiY-0007mf-6n for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 05:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2022 09:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55039-submit@debbugs.gnu.org id=B55039.166262883829879 (code B ref 55039); Thu, 08 Sep 2022 09:21:02 +0000 Original-Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 09:20:38 +0000 Original-Received: from localhost ([127.0.0.1]:57268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDi9-0007lr-QZ for submit@debbugs.gnu.org; Thu, 08 Sep 2022 05:20:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDi7-0007lc-Fq for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 05:20:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDi2-0000zx-7K; Thu, 08 Sep 2022 05:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hccm1HQcMgCRvKfTVDI1+/2Y7RY8p/seV0XiGV0vGS0=; b=YCqAT2ZgBFhy 2NbTO0s938VLOBAWmS+eNulrnpcWKo5E01reLD+jmXMGSdfV8680VHxaDr6E1mAvoYeiltlEb+K0C x11mRY1eUjPlvpxOKXZy/TaGSIqhnnqWTLWxBmooh4i6a9SR2CfEcqcOOqyNMZVl0nVlDxRWwj94S xqaZQDojFkeH+qqLxBvye08VyO+XYetcNOQ2F9YgG053gKwqiwoGMaHPKrvmL9P/9vxKRDlX2Tj71 HZf4TdHh8URPVP5hxvEV+KI+dOkstCnzdw6ab3TpuaRuWgkUd1Kkv0CY3MwnJ+cxu9HsHQcMxHOeP dBjSwmdzMQKHQ1hUJs3cGA==; Original-Received: from [87.69.77.57] (port=4230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDi0-0000H4-Ml; Thu, 08 Sep 2022 05:20:29 -0400 In-Reply-To: <87sfl26ypw.fsf@posteo.net> (message from Philip Kaludercic on Thu, 08 Sep 2022 08:45:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241851 Archived-At: > From: Philip Kaludercic > Cc: larsi@gnus.org, 55039@debbugs.gnu.org > Date: Thu, 08 Sep 2022 08:45:47 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org > >> Date: Tue, 06 Sep 2022 20:11:57 +0000 > >> > >> >> Also, as the entire point of > >> >> the patch was that emacs.git is using relative path names, should a > >> >> .dir-locals.el variable be set to ensure this is done? > >> > > >> > I guess so, yes. But what would happen to people who use Emacs > >> > versions before 29? > >> > >> It should have no effect. > > > > Unfortunately, this is not true, at least not the way this was > > implemented in our .dir-locals.el. Now, whenever I visit _any_ file > > in the repository, I get this warning pop up: > > > > The local variables list in d:/gnu/git/emacs/trunk/ > > contains values that may not be safe (*). > > > > Do you want to apply it? You can type > > y -- to apply the local variables list. > > n -- to ignore the local variables list. > > ! -- to apply the local variables list, and permanently mark these > > values (*) as safe (in the future, they will be set automatically.) > > i -- to ignore the local variables list, and permanently mark these > > values (*) as ignored > > > > tab-width : 8 > > sentence-end-double-space : t > > fill-column : 70 > > emacs-lisp-docstring-fill-column : 65 > > bug-reference-url-format : "https://debbugs.gnu.org/%s" > > * diff-add-log-use-relative-names : t > > indent-tabs-mode : nil > > electric-quote-comment : nil > > electric-quote-string : nil > > mode : bug-reference-prog > > > > and I _must_ type a response. If I answer !, Emacs will write to my > > init file, which I'm not sure I like; if I type y, I will have to do > > that for every file I visit. > > I see, should I revert the change? Is it possible to make the setting dependent on the Emacs version? I don't think there's a need to revert, even if we cannot make this better. Assuming people want this setting very much, that is. Just something to remember for the future: introducing these is not cost-free. > > This is the nuisance caused by immediately adding newly introduced > > variables into file-local or directory-local settings to our > > repository. We should keep this in mind when introducing such stuff. > > Generally speaking, the ability to set a variable only if the symbol is > bound would be useful for features like these. I don't think that's possible in practice, since many variables are loaded only when needed. But if I'm wrong, then yes, it would be good to have such a capability.