From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: larsi@gnus.org, 55039@debbugs.gnu.org
Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries
Date: Thu, 08 Sep 2022 12:20:13 +0300 [thread overview]
Message-ID: <838rmufcj6.fsf@gnu.org> (raw)
In-Reply-To: <87sfl26ypw.fsf@posteo.net> (message from Philip Kaludercic on Thu, 08 Sep 2022 08:45:47 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Cc: larsi@gnus.org, 55039@debbugs.gnu.org
> Date: Thu, 08 Sep 2022 08:45:47 +0000
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org
> >> Date: Tue, 06 Sep 2022 20:11:57 +0000
> >>
> >> >> Also, as the entire point of
> >> >> the patch was that emacs.git is using relative path names, should a
> >> >> .dir-locals.el variable be set to ensure this is done?
> >> >
> >> > I guess so, yes. But what would happen to people who use Emacs
> >> > versions before 29?
> >>
> >> It should have no effect.
> >
> > Unfortunately, this is not true, at least not the way this was
> > implemented in our .dir-locals.el. Now, whenever I visit _any_ file
> > in the repository, I get this warning pop up:
> >
> > The local variables list in d:/gnu/git/emacs/trunk/
> > contains values that may not be safe (*).
> >
> > Do you want to apply it? You can type
> > y -- to apply the local variables list.
> > n -- to ignore the local variables list.
> > ! -- to apply the local variables list, and permanently mark these
> > values (*) as safe (in the future, they will be set automatically.)
> > i -- to ignore the local variables list, and permanently mark these
> > values (*) as ignored
> >
> > tab-width : 8
> > sentence-end-double-space : t
> > fill-column : 70
> > emacs-lisp-docstring-fill-column : 65
> > bug-reference-url-format : "https://debbugs.gnu.org/%s"
> > * diff-add-log-use-relative-names : t
> > indent-tabs-mode : nil
> > electric-quote-comment : nil
> > electric-quote-string : nil
> > mode : bug-reference-prog
> >
> > and I _must_ type a response. If I answer !, Emacs will write to my
> > init file, which I'm not sure I like; if I type y, I will have to do
> > that for every file I visit.
>
> I see, should I revert the change?
Is it possible to make the setting dependent on the Emacs version?
I don't think there's a need to revert, even if we cannot make this
better. Assuming people want this setting very much, that is. Just
something to remember for the future: introducing these is not
cost-free.
> > This is the nuisance caused by immediately adding newly introduced
> > variables into file-local or directory-local settings to our
> > repository. We should keep this in mind when introducing such stuff.
>
> Generally speaking, the ability to set a variable only if the symbol is
> bound would be useful for features like these.
I don't think that's possible in practice, since many variables are
loaded only when needed. But if I'm wrong, then yes, it would be good
to have such a capability.
next prev parent reply other threads:[~2022-09-08 9:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:19 bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Philip Kaludercic
2022-04-20 16:01 ` Eli Zaretskii
2022-09-06 11:13 ` Lars Ingebrigtsen
2022-09-06 11:24 ` Eli Zaretskii
2022-09-06 11:30 ` Lars Ingebrigtsen
2022-09-06 12:45 ` Philip Kaludercic
2022-09-06 14:34 ` Philip Kaludercic
2022-09-06 14:39 ` Lars Ingebrigtsen
2022-09-06 14:58 ` Robert Pluim
2022-09-06 15:02 ` Philip Kaludercic
2022-09-06 15:46 ` Eli Zaretskii
2022-09-06 20:11 ` Philip Kaludercic
2022-09-08 7:07 ` Eli Zaretskii
2022-09-08 8:45 ` Philip Kaludercic
2022-09-08 9:20 ` Eli Zaretskii [this message]
2022-09-08 12:11 ` Lars Ingebrigtsen
2022-09-08 12:19 ` Visuwesh
2022-09-08 12:33 ` Lars Ingebrigtsen
2022-09-08 12:43 ` Philip Kaludercic
2022-09-08 12:44 ` Lars Ingebrigtsen
2022-09-08 12:53 ` Philip Kaludercic
2022-09-08 12:56 ` Lars Ingebrigtsen
2022-09-11 8:16 ` Philip Kaludercic
2022-09-11 11:08 ` Lars Ingebrigtsen
2022-09-08 12:56 ` Robert Pluim
2022-09-08 13:10 ` Lars Ingebrigtsen
2022-09-08 13:13 ` Visuwesh
2022-09-08 12:52 ` Robert Pluim
2022-09-06 16:13 ` Juri Linkov
2022-09-06 20:10 ` Philip Kaludercic
2022-09-07 10:08 ` Robert Pluim
2022-09-07 12:48 ` Lars Ingebrigtsen
2022-09-07 13:27 ` Eli Zaretskii
2022-09-07 15:53 ` Philip Kaludercic
2022-09-07 18:12 ` Eli Zaretskii
2022-09-07 18:27 ` Philip Kaludercic
2022-09-07 18:46 ` Eli Zaretskii
2022-09-07 21:23 ` Philip Kaludercic
2022-09-08 5:38 ` Eli Zaretskii
2022-09-08 6:22 ` Philip Kaludercic
2022-09-08 2:58 ` Richard Stallman
2022-09-08 6:18 ` Philip Kaludercic
2022-04-22 3:03 ` Richard Stallman
2022-04-22 5:29 ` Eli Zaretskii
2022-04-23 3:46 ` Richard Stallman
2022-04-23 6:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rmufcj6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55039@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.