all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Randy Taylor <dev@rjt.dev>, Yuan Fu <casouri@gmail.com>
Cc: aqua0210@foxmail.com, 59498@debbugs.gnu.org, mardani29@yahoo.es
Subject: bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled
Date: Sat, 26 Nov 2022 13:18:01 +0200	[thread overview]
Message-ID: <838rjyt15i.fsf@gnu.org> (raw)
In-Reply-To: <6_5zC6qq_eQV2whwZ7epZMUlEN-yk5iOlJBLuVnNDLzl4RUGCPFnbIN12pG-DyNvCAYlRJTTopEe_RxX2_B7nSJQyBCJrzo915uBA51qW8A=@rjt.dev> (message from Randy Taylor on Thu, 24 Nov 2022 14:39:19 +0000)

> Cc: Yuan Fu <casouri@gmail.com>, 59498@debbugs.gnu.org,
>  Daniel Martín <mardani29@yahoo.es>
> Date: Thu, 24 Nov 2022 14:39:19 +0000
> From: Randy Taylor <dev@rjt.dev>
> 
> diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
> index fc35d9aedda..48f504214e2 100644
> --- a/lisp/progmodes/c-ts-mode.el
> +++ b/lisp/progmodes/c-ts-mode.el
> @@ -570,6 +570,8 @@ c++-ts-mode
>    (setq-local comment-start "// ")
>    (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *")
>    (setq-local comment-end "")
> +  (setq-local treesit-comment-start (rx "/" (or (+ "/") (+ "*"))))
> +  (setq-local treesit-comment-end (rx (+ (or "*")) "/"))
>  
>    (treesit-parser-create 'cpp)

Thanks, but this doesn't look right to me: why should c++-ts-mode set
variables for treesit.el?  It is more likely that treesit.el should use the
buffer-local values of comment-start and comment-end instead, and fall back
on generic values (if they make sense) only if the local values are not set.

Yuan, WDYT?





  parent reply	other threads:[~2022-11-26 11:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  2:24 bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled Eason Huang
2022-11-23  8:44 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 10:53   ` Eason Huang
2022-11-24 14:39     ` Randy Taylor
2022-11-25 12:56       ` Eason Huang
2022-11-26 11:18       ` Eli Zaretskii [this message]
2022-11-26 22:11         ` Yuan Fu
2022-11-27  6:24           ` Eli Zaretskii
2022-11-27  7:18             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-27  7:24               ` Eli Zaretskii
2022-11-27 22:21                 ` Yuan Fu
2022-11-28  0:24                   ` Stefan Kangas
2022-12-18  9:57                     ` Eli Zaretskii
2022-12-18 22:49                       ` Yuan Fu
2022-12-19 13:51                         ` Eli Zaretskii
2022-12-20  1:56                           ` Yuan Fu
2022-12-20 15:18                             ` Eli Zaretskii
2022-12-21  0:37                               ` Yuan Fu
2022-11-28 13:59                   ` Eason Huang
2022-11-27 22:00               ` Yuan Fu
     [not found] <m24juq9zn6.fsf@foxmail.com>
2022-11-30 21:33 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rjyt15i.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59498@debbugs.gnu.org \
    --cc=aqua0210@foxmail.com \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.