From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 20:17:30 +0200 Message-ID: <838rjdu7np.fsf@gnu.org> References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59935@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 19:18:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4Qty-0000UT-GA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 19:18:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4Qtq-00016Q-Gz; Sun, 11 Dec 2022 13:18:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Qtm-000162-Kv for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4Qtm-0004R7-5U for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4Qtl-0001R1-QD for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707826605498 (code B ref 59935); Sun, 11 Dec 2022 18:18:01 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:17:40 +0000 Original-Received: from localhost ([127.0.0.1]:47500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QtP-0001Qc-UL for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:17:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QtN-0001QW-Jb for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:17:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QtH-0004MM-RB; Sun, 11 Dec 2022 13:17:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z+GlW5d1gRMloCJL8kiWs/qhvUrwcidnHSV4Fkh5HLQ=; b=ebYa/J2q2+nx VV1V5Hl7zNa4RK9NMz5a2g62iincqSLD9LmohTeVux+ruRZ9m5/ZgRJ7OgQfPfIWP4zfQUhYNXqTc 0nYO5b4RdJDruolVeXvq8V6rtod2bW9OXk8vc/JRM65OR6KEKMyu5Dialbzum3qRH40fm7KtYSEVO nYOZuDVxc+w2Min4t8PxlbWj5FLM2qPKPqkIuJ3YzTyipjLwzrCZHX+eK8b7xgap4WgMj9y+vr2vt 15ea+xDCkRnQZaMH3L40zBdXGx0vOIVfrHwB8mt0FFBAIxFkHXm/0sGr7OfRth2rUectbwLzIINKL 1Dody4JtCtaWAAkvPe7H1Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QtH-0000sD-4l; Sun, 11 Dec 2022 13:17:31 -0500 In-Reply-To: <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> (message from Dmitry Gutov on Sun, 11 Dec 2022 20:12:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250643 Archived-At: > Date: Sun, 11 Dec 2022 20:12:25 +0200 > Cc: 59935@debbugs.gnu.org > From: Dmitry Gutov > > On 11/12/2022 19:49, Eli Zaretskii wrote: > > Thanks, but I hope you don't intend to ask to install this on the > > release branch. And changing back the signature of > > list-buffers-noselect is extremely problematic, even though we changed > > it only for Emacs 29. > > The problem with *not* changing it, is we don't seem to be able to use > the new calling convention to implement project-list-buffers working > without this performance problem. > > We could just use the old (private) interface, but then the new calling > convention will be left without any users at all. We extended it in > order to implement this feature anyway. I don't think I follow. Why not leave alone that additional PREDICATE argument of list-buffers-noselect, and add a feature where the BUFFER-LIST argument could be a function? That's be a compatible change. Just keep the PREDICATE argument and the code which supports it, and document that if PREDICATE is a function, BUFFER-LIST cannot be a function.