From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60569: 29.0.60; vc-pull-and-push unsupported on non-git vcs Date: Mon, 23 Jan 2023 14:00:34 +0200 Message-ID: <838rhtjw9p.fsf@gnu.org> References: <864jt58l8f.fsf@mail.linkov.net> <861qnr4yet.fsf@mail.linkov.net> <86edrm4gyk.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60569@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 23 13:01:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJvW4-0008JU-F4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Jan 2023 13:01:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJvVn-0008OS-Cu; Mon, 23 Jan 2023 07:01:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJvVW-0008La-S7 for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 07:01:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJvVW-0000Uc-BK for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 07:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJvVW-00027x-43 for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 07:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2023 12:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60569 X-GNU-PR-Package: emacs Original-Received: via spool by 60569-submit@debbugs.gnu.org id=B60569.16744752388130 (code B ref 60569); Mon, 23 Jan 2023 12:01:02 +0000 Original-Received: (at 60569) by debbugs.gnu.org; 23 Jan 2023 12:00:38 +0000 Original-Received: from localhost ([127.0.0.1]:53495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJvV7-000274-O6 for submit@debbugs.gnu.org; Mon, 23 Jan 2023 07:00:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJvV5-00026o-A2 for 60569@debbugs.gnu.org; Mon, 23 Jan 2023 07:00:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJvUz-0000Q5-Gl; Mon, 23 Jan 2023 07:00:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TSGoYt1UgT5OeGk9wtQhaEEBsOBogkMhuV7fcV3nwC4=; b=Qerq4kXOyMIp PpITFjcsoJphmmtPbfZCwB2dKjxTvTwbS1RYcF/Z0pxYtkJuk5a6UgjZB5m0/I3gZ4k8GsbmDsSBa W/hOHqkq+Ppf4fw0IvHaNQQZpqhch1orT5+vArJbRe5LqOXGX0z/oOzNxl+zi9livqxFZ6B7zEHl9 M/3UykMqrAV0bvOr/1tYmPAil4wjaPLx6I/8nyQYj+/JW8Sn4SfFnFayukVQZRImdGsg+Fc2g1rrx hTbc+B6gu5y0wV3Fv1tIp4ZA6GG+HbhaboIjwim0WVm/sX9L5G3RNTtk5tNyDYkW1nmjujHgVdfCI aWzShr8r6odiKqhLbJvZfQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJvUx-0005hB-5w; Mon, 23 Jan 2023 07:00:29 -0500 In-Reply-To: <86edrm4gyk.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 22 Jan 2023 19:28:03 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253985 Archived-At: > From: Juri Linkov > Date: Sun, 22 Jan 2023 19:28:03 +0200 > > > Thanks for keeping VC generic. > > Here is a one-line patch that adds support for vc-bzr. > > Eli, is it ok to install this on the emacs-29 branch? > I briefly tested it on bzr, so it should be quite safe. > > diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el > index 6443f6d57aa..404800cb208 100644 > --- a/lisp/vc/vc-bzr.el > +++ b/lisp/vc/vc-bzr.el > @@ -381,7 +381,8 @@ vc-bzr--pushpull > (setq-local compile-command > (concat vc-bzr-program " " command " " > (if args (mapconcat #'identity args " ") ""))))) > - (vc-set-async-update buf)))) > + (vc-set-async-update buf) > + (get-buffer-process buf)))) Looks OK to me, but could you add some details regarding why this change is needed? Did we change our requirements from the return value of the pushpull method? Or did vc-set-async-update change its behavior and no longer returns the process object? Or something else? Thanks.