From: Eli Zaretskii <eliz@gnu.org>
To: Andrew De Angelis <bobodeangelis@gmail.com>
Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org
Subject: bug#60703: Patches to xwidget code
Date: Wed, 22 Feb 2023 15:27:00 +0200 [thread overview]
Message-ID: <838rgpsue3.fsf@gnu.org> (raw)
In-Reply-To: <CAP5CrM1vRYi8GYC5TBx+aYa435KYiLTG1vTSgNuYeivLQ77n2A@mail.gmail.com> (message from Andrew De Angelis on Tue, 21 Feb 2023 00:24:06 -0500)
> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Tue, 21 Feb 2023 00:24:06 -0500
> Cc: luangruo@yahoo.com, 60703@debbugs.gnu.org
>
> Done. (git diff forked/emacs-29 > emacs-29-xwidget-patches.patch)
>
> Let me know if there's anything I should do. Thanks!
Thanks, what is missing now is the commit log message. Please see
CONTRIBUTE and the examples in the Git repository, for how we format
the log messages.
One minor comment to the code:
> +DEFUN ("xwidget-webkit-estimated-load-progress",
> + Fxwidget_webkit_estimated_load_progress, Sxwidget_webkit_estimated_load_progress,
> + 1, 1, 0, doc: /* Get the estimated load progress of XWIDGET, a WebKit widget.
> +Return a value ranging from 0.0 to 1.0, based on how close XWIDGET
> +is to completely loading its page. */)
The first line of a doc string should be a single complete sentence.
This is because commands like "M-x apropos" show only the first line.
(Yes, I'm aware that you just moved existing code, but still: let's
fix this while we are at that.)
next prev parent reply other threads:[~2023-02-22 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 5:14 bug#60703: Patches to xwidget code Andrew De Angelis
2023-01-10 9:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-10 9:59 ` Po Lu
2023-01-10 13:40 ` Eli Zaretskii
2023-01-10 23:33 ` Andrew De Angelis
2023-01-11 1:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 6:13 ` Andrew De Angelis
2023-01-21 7:16 ` Eli Zaretskii
2023-01-21 15:32 ` Andrew De Angelis
2023-01-21 15:41 ` Eli Zaretskii
2023-01-26 23:45 ` Andrew De Angelis
2023-01-27 0:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 21:00 ` Andrew De Angelis
2023-02-20 2:41 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 11:47 ` Eli Zaretskii
2023-02-21 5:24 ` Andrew De Angelis
2023-02-22 13:27 ` Eli Zaretskii [this message]
2023-02-24 3:47 ` Andrew De Angelis
2023-03-02 10:57 ` Eli Zaretskii
2023-03-04 23:00 ` Andrew De Angelis
2023-03-05 0:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rgpsue3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60703@debbugs.gnu.org \
--cc=bobodeangelis@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.