From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63337: [PATCH] package-vc--build-documentation: Fix relative @include statements Date: Fri, 12 May 2023 10:14:31 +0300 Message-ID: <838rdu3tt4.fsf@gnu.org> References: <87fs89qg9y.fsf@breatheoutbreathe.in> <87cz3cea4k.fsf@posteo.net> <87pm7c7zfs.fsf@breatheoutbreathe.in> <83zg6gc5yp.fsf@gnu.org> <87sfc8gd9s.fsf@posteo.net> <87fs877tgz.fsf@breatheoutbreathe.in> <875y936iec.fsf@posteo.net> <87y1lyhbfy.fsf@breatheoutbreathe.in> <83sfc6azol.fsf@gnu.org> <87bkitgj3c.fsf@breatheoutbreathe.in> <87lehwfzli.fsf@posteo.net> <87a5ybsjum.fsf@breatheoutbreathe.in> <875y8yxct4.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25046"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63337@debbugs.gnu.org, joseph@breatheoutbreathe.in To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 09:14:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxMys-0006Jq-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 09:14:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxMyb-0001t0-3E; Fri, 12 May 2023 03:14:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMyY-0001sm-NM for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxMyY-0004Ms-Ed for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxMyY-0008JJ-5a for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63337-submit@debbugs.gnu.org id=B63337.168387561831905 (code B ref 63337); Fri, 12 May 2023 07:14:02 +0000 Original-Received: (at 63337) by debbugs.gnu.org; 12 May 2023 07:13:38 +0000 Original-Received: from localhost ([127.0.0.1]:53899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMyA-0008IW-9s for submit@debbugs.gnu.org; Fri, 12 May 2023 03:13:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMy9-0008II-5o for 63337@debbugs.gnu.org; Fri, 12 May 2023 03:13:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMy2-0004Aj-MG; Fri, 12 May 2023 03:13:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HFyRpY8x3Q4EAhsULT6TEjApxBzOXJFjgNAHwd6JI3E=; b=VUfTFWzPlK+W jDQt7k9EIhCvQGRf+F+hyGLWKMcJjrFgiKdH1ERxH4I2sH6rzVh/fTDL2NzUaW8/o8PQ4wyqA8b/2 7wbMi97ER/P4wV4C7FSrhtN+B/V8xCYGyp6vFtJ3YkUZXu+1H+BYPH/xdtDSz/WI1nFkEWFPDQLcA Vp2ICuINAlAz+y01mYprTzK30DhMuOYZlKTxub2qquJ4cNV6YgAgvnzkeW/uB3Jcg1lpatZMiqAFt 0vlqlmoWEVnBMh12cVywvlp6YmKVojpX6IeTYMjv590KbC09tbRCcuchdHCcPCrsNUxhXr71P8tQK dWX0+qNYz5dmDFCWAYG7nw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMxu-0003w9-Pi; Fri, 12 May 2023 03:13:29 -0400 In-Reply-To: <875y8yxct4.fsf@posteo.net> (message from Philip Kaludercic on Fri, 12 May 2023 06:51:19 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261611 Archived-At: > From: Philip Kaludercic > Cc: Eli Zaretskii , 63337@debbugs.gnu.org > Date: Fri, 12 May 2023 06:51:19 +0000 > > One issue I still notice in this case is that if the file doesn't exist, > the issue is raised by `insert-file-contents' which aborts the entire > installation. Does checking the existence of the file, and continuing > on if this is not the case make sense: If the file's (non)existence is the problem, then checking that up front is an okay solution, IMO. Are there any downsides to doing that?