all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Sedach <vas@oneofus.la>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 64311@debbugs.gnu.org
Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
Date: Mon, 03 Jul 2023 20:17:31 +0300	[thread overview]
Message-ID: <838rbwncd0.fsf@gnu.org> (raw)
In-Reply-To: <87zg4dsz9y.fsf@t510.orion.oneofus.la> (message from Vladimir Sedach on Mon, 03 Jul 2023 11:03:37 -0600)

> From: Vladimir Sedach <vas@oneofus.la>
> Cc: 64311@debbugs.gnu.org
> Date: Mon, 03 Jul 2023 11:03:37 -0600
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> > I think the alternative patch below solves all those issues.  If you
> > disagree, pleased tell what left-over problems you see after applying
> > that patch.
> 
> How should defvaralias be used?
> 
> On the master branch I count 74 defvaralias declarations in lisp/,
> excluding lisp/obsolete/ (there are some more generated dynamically
> by org-babel). Of these, 73 are used for variable rename refactoring
> (the 1 other use is vhdl-last-input-event as a compatibility shim for
> xemacs).
> 
> There were 2 things that to me looked wrong with the existing
> defvaralias declaration in shell.el:
> 
> 1. As far as I can tell, every declaration aside from shell.el is of
>    the form (defvaralias old-variable new-variable). The one in
>    shell.el is the other way around.
> 
> 2. There are only 2 occurrences where the old variable is still
>    referenced in Emacs code: erc-join-buffer and shell-dirtrackp
> 
> Isn't the point of defvaralias in removing uses of the old variable
> name from Emacs code?

I'm not sure.  You may be right.  Let's see if Stefan (CC'ed) has any
comments.

But in any case, given how long we have this arrangement, I wouldn't
make any changes in it unless it causes real problems.  And I think
after installing the simple changes I proposed there are no real
problems left to justify such changes.





  reply	other threads:[~2023-07-03 17:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  4:39 bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Vladimir Sedach
2023-06-27 11:18 ` Eli Zaretskii
2023-06-27 14:09   ` Vladimir Sedach
2023-06-27 15:52     ` Eli Zaretskii
2023-06-28  0:07       ` Vladimir Sedach
2023-06-28 11:46         ` Eli Zaretskii
2023-06-28 16:43           ` Vladimir Sedach
2023-06-28 18:31             ` Eli Zaretskii
2023-06-28 20:14               ` Vladimir Sedach
2023-06-29  4:57                 ` Eli Zaretskii
2023-06-29 16:26                   ` Vladimir Sedach
2023-06-29 18:10                     ` Eli Zaretskii
2023-06-29 19:24                       ` Vladimir Sedach
2023-06-30  5:40                         ` Eli Zaretskii
2023-06-30 16:47                           ` Vladimir Sedach
2023-07-02  6:39                             ` Eli Zaretskii
2023-07-03 17:03                               ` Vladimir Sedach
2023-07-03 17:17                                 ` Eli Zaretskii [this message]
2023-07-04 14:28                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 16:05                                 ` Eli Zaretskii
2023-07-04 18:34                                   ` Vladimir Sedach
2023-07-04 20:36                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 22:27                                     ` Vladimir Sedach
2023-07-04 23:42                                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-06 20:30                                         ` Vladimir Sedach
2023-07-08  8:30                                           ` Eli Zaretskii
2023-07-08 16:18                                             ` Vladimir Sedach
2023-07-08 16:31                                               ` Eli Zaretskii
2023-07-04  3:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 11:21   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838rbwncd0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64311@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=vas@oneofus.la \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.