From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: yantar92@posteo.net, 64596@debbugs.gnu.org
Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update)
Date: Mon, 17 Jul 2023 14:20:04 +0300 [thread overview]
Message-ID: <838rbe944b.fsf@gnu.org> (raw)
In-Reply-To: <jwv8rbf8q4n.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 16 Jul 2023 18:19:57 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: yantar92@posteo.net, 64596@debbugs.gnu.org
> Date: Sun, 16 Jul 2023 18:19:57 -0400
>
> > That's not all of the uses of this flag. Here's one example of other
> > uses:
> >
> > if (some_windows
> > && !f->redisplay
> > && !w->redisplay
> > && !XBUFFER (w->contents)->text->redisplay)
> > continue;
> >
> > (This avoids updating the tool bar and the tab bar of the frame, and
> > there's a similar condition that avoids updating the frame's title.)
>
> Right, but notice that what we're fundamentally checking is whether `w`
> (which is the frame's selected window here) needs to be updated, because
> that's the one currently "occupying" the tool-bar.
But testing the frame's redisplay flag will produce false positives,
because many changes that require to redraw the frame's windows don't
affect the tool bar or the frame's title.
> FWIW, I don't know why we don't also check
> `XBUFFER(w->contents)->redisplay` here.
We do:
if (some_windows
&& !f->redisplay
&& !w->redisplay
&& !XBUFFER (w->contents)->text->redisplay) <<<<<<<<<<<
continue;
> Also, I still don't see why that makes you think:
>
> frame's redisplay flag is what causes us to consider a frame in the
> first place.
>
> Indeed, a frame's redisplay flag may be such a reason, but a window's
> flag or its text buffer's may be the reason instead. A frame's
> `redisplay` flag does not need to be set for us to consider it.
No, my point is that fset_redisplay shouldn't set
windows_or_buffers_changed.
next prev parent reply other threads:[~2023-07-17 11:20 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 13:00 bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Ihor Radchenko
2023-07-13 13:34 ` Eli Zaretskii
2023-07-13 17:19 ` Ihor Radchenko
2023-07-13 19:03 ` Eli Zaretskii
2023-07-14 11:53 ` Ihor Radchenko
2023-07-14 12:25 ` Eli Zaretskii
2023-07-14 13:48 ` Ihor Radchenko
2023-07-14 14:20 ` Eli Zaretskii
2023-07-14 14:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 14:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 15:56 ` Eli Zaretskii
2023-07-13 17:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-13 19:08 ` Eli Zaretskii
2023-07-13 21:00 ` Ihor Radchenko
2023-07-13 22:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 6:14 ` Eli Zaretskii
2023-07-14 14:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 16:00 ` Eli Zaretskii
2023-07-14 17:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 17:46 ` Ihor Radchenko
2023-07-14 19:06 ` Eli Zaretskii
2023-07-15 7:01 ` Eli Zaretskii
2023-07-15 7:22 ` Ihor Radchenko
2023-07-15 8:52 ` Eli Zaretskii
2023-07-15 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 15:22 ` Eli Zaretskii
2023-07-15 16:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 16:16 ` Eli Zaretskii
2023-07-15 17:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 19:04 ` Eli Zaretskii
2023-07-16 10:38 ` Ihor Radchenko
2023-07-16 11:26 ` Eli Zaretskii
2023-07-15 18:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 19:18 ` Eli Zaretskii
2023-07-15 19:28 ` Eli Zaretskii
2023-07-15 19:43 ` Ihor Radchenko
2023-07-15 23:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 4:57 ` Eli Zaretskii
2023-07-16 5:49 ` Ihor Radchenko
2023-07-16 7:15 ` Eli Zaretskii
2023-07-16 8:26 ` martin rudalics
2023-07-16 8:40 ` Ihor Radchenko
2023-07-16 8:56 ` Eli Zaretskii
2023-07-16 9:41 ` Ihor Radchenko
2023-07-16 10:30 ` Eli Zaretskii
2023-07-16 8:50 ` Eli Zaretskii
2023-07-17 8:30 ` martin rudalics
2023-07-15 22:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 5:17 ` Eli Zaretskii
2023-07-16 5:52 ` Ihor Radchenko
2023-07-16 7:16 ` Eli Zaretskii
2023-07-16 7:28 ` Ihor Radchenko
2023-07-16 7:35 ` Eli Zaretskii
2023-07-16 14:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 14:27 ` Eli Zaretskii
2023-07-16 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 10:22 ` Ihor Radchenko
2023-07-16 10:37 ` Eli Zaretskii
2023-07-16 10:47 ` Ihor Radchenko
2023-07-16 11:31 ` Eli Zaretskii
2023-07-16 14:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 14:45 ` Eli Zaretskii
2023-07-16 16:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 17:11 ` Eli Zaretskii
2023-07-16 17:20 ` Eli Zaretskii
2023-07-16 18:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 19:06 ` Eli Zaretskii
2023-07-16 22:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-17 11:20 ` Eli Zaretskii [this message]
2023-07-17 12:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-17 13:07 ` Eli Zaretskii
2023-07-16 19:27 ` Eli Zaretskii
2023-07-16 20:12 ` Ihor Radchenko
2023-07-17 2:23 ` Eli Zaretskii
2023-07-17 9:22 ` Ihor Radchenko
2023-07-17 11:54 ` Eli Zaretskii
2023-07-17 12:00 ` Ihor Radchenko
2023-07-17 12:22 ` Eli Zaretskii
2023-07-18 9:52 ` Ihor Radchenko
2023-07-18 11:51 ` Eli Zaretskii
2023-07-19 10:11 ` Ihor Radchenko
2023-07-19 14:55 ` Eli Zaretskii
2023-07-19 15:50 ` Ihor Radchenko
2023-07-19 16:30 ` Eli Zaretskii
2023-07-20 9:40 ` Ihor Radchenko
2023-07-20 10:23 ` Eli Zaretskii
2023-07-21 2:41 ` Richard Stallman
2023-07-21 5:48 ` Eli Zaretskii
2023-07-23 3:01 ` Richard Stallman
2023-07-14 19:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rbe944b.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64596@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.