From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65250: 30.0.50; "C-h f" is much slower on the master branch Date: Sat, 12 Aug 2023 18:49:30 +0300 Message-ID: <838ragdzw5.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1905"; mail-complaints-to="usenet@ciao.gmane.io" To: 65250@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 17:50:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUqsu-0000IW-RR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 17:50:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUqsO-000115-Lq; Sat, 12 Aug 2023 11:50:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUqsM-0000za-RP for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 11:50:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUqsM-0005A7-I7 for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 11:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUqsM-0000JV-DR for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65250 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1691855349902 (code B ref -1); Sat, 12 Aug 2023 15:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Aug 2023 15:49:09 +0000 Original-Received: from localhost ([127.0.0.1]:56671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUqrU-0000EU-MW for submit@debbugs.gnu.org; Sat, 12 Aug 2023 11:49:09 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:45812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUqrR-0000Dx-0J for submit@debbugs.gnu.org; Sat, 12 Aug 2023 11:49:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUqrL-0000vS-9O for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 11:48:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUqrL-0004v2-14 for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 11:48:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=25m7hNC6gWsPFXg9RoPKoGjItsEdM33lstymcMLBWDA=; b=MNX4mrRZenGlvU bO7/Z5VPyJu+G5f0S9T4iwbaXIPLvfQ5+X60e52ffJdfb3qkHpBaj9WGXdFX5FTqvnixVnC2HeGvr x+7WPuIhG5Nxt1YmhdTJDY0xjCNjU1lRf6BL7fMsTQ5tLGNx1l/DoSQcXJGQuSCiRF7X53ndO0aX9 Hh/13w6MO2ODhFSEZi9UWRrnCKjD+z4itSPueVNTw2/QhyhcZ480hLXn+5C4mhjz8/qQ8QkyWsuYm P54i3S81WV/lkFTUeIJx75opN8pe80QpCIYuuf2D+tyEfcpdxJ+ApMDgNxzycF4rk6KnBxpy/iRgc uCeMH37KFRDto0SHFppg==; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267312 Archived-At: To reproduce: emacs -Q C-h f dictionary-search RET (almost any other function will do, I think). This takes a whopping 6.6 sec of CPU on master, vs 2.4 sec on the emacs-29 branch. These are both unoptimized builds, but even so, 6.6 seconds of CPU time for looking up a doc string of a function is too much, I think. The patch below fixes the problem in a build without native-compilation, but won't help in a build with native-compilation. I wonder why comp-function-type-spec is so expensive? In GNU Emacs 30.0.50 (build 417, i686-pc-mingw32) of 2023-08-12 built on HOME-C4E4A596F7 Repository revision: d3dae88e6cc8118c875957ba0347be9599014b34 Repository branch: master Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 42844 17019) (symbols 48 6336 0) (strings 16 16702 3269) (string-bytes 1 401689) (vectors 16 9351) (vector-slots 8 147820 16098) (floats 8 23 25) (intervals 40 276 95) (buffers 896 10)) Here's the patch I promised: diff --git a/lisp/help-fns.el b/lisp/help-fns.el index fc8f431..bedc5a9 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -715,7 +715,8 @@ help-fns--signature (unless (and (symbolp function) (get function 'reader-construct)) (insert high-usage "\n") - (when-let* ((res (comp-function-type-spec function)) + (when-let* ((res (and (native-comp-available-p) + (comp-function-type-spec function))) (type-spec (car res)) (kind (cdr res))) (insert (format