From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oGmFEext+GRF4QAAG6o9tA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 14:17:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oGmFEext+GRF4QAAG6o9tA (envelope-from ) for ; Wed, 06 Sep 2023 14:17:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EBBA761A06 for ; Wed, 6 Sep 2023 14:17:47 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=m8k0wpwX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694002668; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2r/MHYvEoAcx8cl5F0CXtpxhb8IKB6MFP1BKJ3bSCqI=; b=C7VM6/kgQHF8jv36eUv8PW3Oz12DQwOC3MoJgo9ITmFYDEt+20su3fpVPI9iKfj4ZiW96w GFEAD1wl7Wxivs/lqjvlMijCNo5vNxhvJ3QeXd2mFRz7hBse5iK7EumvEtkxtZioonTcbu GaHVu8cvFkgnGnSYQpXHYY4Yqu9hXGsq4ZXuv0bWFB/ReCK+EuD2N2Tx+pCqgnGL9HrDO+ R22EZERoejunBMMiEkUMZX2ebeBQDjLiLkIQHmkv5g8dKqAl0A38tnaKRHrpYP5q9gkWpm rhPvtQiuJxJj9eZ3EaXhNNtxolPsBq5sVFV3UKorMfeEjqMi+AnsP70P+McqLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=m8k0wpwX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694002668; a=rsa-sha256; cv=none; b=TMibg6t3gceLUrCzthQgd/jmxs17sHXORb2Nrom6R/bnfeWP1rdJ+IW4q+M8ldoyMwrxAc YbKd9Ch2FJKfYkfve4QM+PDLM3UkeTg7AZHXNBmpv4sZrcko1D8JqBMkXCCUOpgKvdHd3t xsCFZEkL9JynKbk+OjjMGriExCPLc6G782KH13K+oSw/hYdgIHtaeBMzsZgEemTR1G2Pwq 7Lm2NRUhSOOWZ6aUXsuafH3Jmb6YQTsrR+uemFcmJ20Ex5jF+2XHqjSnDG4igt3KXsxBO5 mWebxa6rBIz6ytA7yD8Z5w7PRR5fV/m7P9rv7MPXcPZ381dA9KAdjHxCCuzFwg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdrSw-0007P5-El; Wed, 06 Sep 2023 08:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdrSu-0007HY-2Y for emacs-orgmode@gnu.org; Wed, 06 Sep 2023 08:17:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdrSs-0001Jt-S2; Wed, 06 Sep 2023 08:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2r/MHYvEoAcx8cl5F0CXtpxhb8IKB6MFP1BKJ3bSCqI=; b=m8k0wpwXo0fw FuHRfMmZ9oz0Q0eeID6Quj3uJibCUNHzqk038y+69wDxhOcmgnhWOwzF3Sp3fTdV+2RfCSn4aHkAx PzGcSPWNdVg7GLmu6v0xCDeMotxscHUQlx0EZpVoU5AAeoXZdZ9LWY/M3Hk4WXSWBBQGm6dWjruJG BCHf3Be0MEHg3yDCZlfk52m9m1XWCjAiBFPy4rDlDq/ImnEXf12lD2iNAxjGF8OPfQJPw6kKJxoFD eVBcJPJpVc9KfoA6aiIxxhIOrOPabxp/0sTA+f29Ch6rEdEmnvjZsEPgkqRV98U4FJkaV6bReS8se AsKfvmPwz017XViJ9VyENQ==; Date: Wed, 06 Sep 2023 15:16:42 +0300 Message-Id: <838r9j339x.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko Cc: iota@whxvd.name, 65734@debbugs.gnu.org, emacs-orgmode@gnu.org In-Reply-To: <87o7ifu2v8.fsf@localhost> (message from Ihor Radchenko on Wed, 06 Sep 2023 08:23:23 +0000) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <875y4oaban.fsf@whxvd.name> <83bkeg4o1u.fsf@gnu.org> <87o7ifu2v8.fsf@localhost> X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: EBBA761A06 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -10.72 X-Spam-Score: -10.72 X-TUID: TRjCPQdL47SK > From: Ihor Radchenko > Cc: Sebastian Miele , 65734@debbugs.gnu.org, > emacs-orgmode@gnu.org > Date: Wed, 06 Sep 2023 08:23:23 +0000 > > Eli Zaretskii writes: > > >> The following would do it. I think I tested it rather thoroughly. > >> During testing I found another bug that is addressed by the let-binding > >> of kill-read-only-ok during the first kill-region below. > > > > Thanks. Sadly, we don't have any tests for this function in our test > > suite, so verifying this non-trivial change will not be easy... > > Then, what should we do to move things forward? I guess the first step > will be writing these missing tests. Yes, that'd be most welcome. > Anything else? How about asking on emacs-devel that people who use kill-whole-line frequently install the patch and run with it for some time? (We could do that after installing the changes on master, of course.)