From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66288: 29.1; Performance regression using pipe for subprocess Date: Fri, 06 Oct 2023 08:34:02 +0300 Message-ID: <838r8g2u2d.fsf@gnu.org> References: <83ttra91nu.fsf@gnu.org> <63df0312-f2e0-49cd-8536-f886d841e88e@chris-hanson.org> <83edid8vmx.fsf@gnu.org> <83bkdh8u2k.fsf@gnu.org> <6d2e1bab-89e0-57cf-598c-96f0e4179428@gutov.dev> <786d8b73-dc9f-42ec-b5ed-4cae99ed5567@chris-hanson.org> <83h6n86x8r.fsf@gnu.org> <278d63e7-c624-4759-2c25-283e2ee60c9a@gutov.dev> <831qeb7fna.fsf@gnu.org> <091483da-26d5-f395-9d66-692d706ac3c6@gutov.dev> <83sf6q6fqz.fsf@gnu.org> <4406fc68-d033-1f88-c244-3c5d138b33ad@cs.ucla.edu> <8be747c8-42e5-f978-d331-b8c36c6d0349@gutov.dev> <83r0m94nzl.fsf@gnu.org> <391fb6f4-163e-45fb-e2f9-311382e0ad93@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18517"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, gregory@heytings.org, eggert@cs.ucla.edu, cph@chris-hanson.org, 66288-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 06 07:35:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qodUP-0004db-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Oct 2023 07:35:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qodU6-0001BK-9k; Fri, 06 Oct 2023 01:34:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qodU4-0001Ay-PL for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 01:34:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qodU4-0001QT-Gd for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 01:34:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qodUM-0002A9-La for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 01:35:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2023 05:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66288 X-GNU-PR-Package: emacs Mail-Followup-To: 66288@debbugs.gnu.org, eliz@gnu.org, cph@chris-hanson.org Original-Received: via spool by 66288-done@debbugs.gnu.org id=D66288.16965704678260 (code D ref 66288); Fri, 06 Oct 2023 05:35:02 +0000 Original-Received: (at 66288-done) by debbugs.gnu.org; 6 Oct 2023 05:34:27 +0000 Original-Received: from localhost ([127.0.0.1]:49016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qodTm-000299-2d for submit@debbugs.gnu.org; Fri, 06 Oct 2023 01:34:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qodTh-00028t-AE for 66288-done@debbugs.gnu.org; Fri, 06 Oct 2023 01:34:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qodTI-0001IF-Vg; Fri, 06 Oct 2023 01:33:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rEMDuG/oY+CCoZkCPlEuE2ggCfi0YqHSz6Prb6GnO+8=; b=XEtIShr+WguO0fdRsqhs Pfr4i9I++i8VQBCAc6XY1auWqhjyZcRQbS64dopsVT8IzVroyLvjp7O7zcCiadEe3I8Rvra/kkXyb XMr2B/+34tYEMhCxiI6lJmgoEmGNd9uVrkbvTaa0ygrXt55PqHjauoh3dV3hb9DIBLgzllhjfbUXd lhyxUwiDgK02C8HlWGAV0BmKsbrXCg4m9NHWods9bgz/msTlCVj0VqatEY7JSj9qZvTHNFiW89Rqv eWV2L7YqnNKkS0PrDV/9WXLsoF/aoCtU+hWEPpQxykUt0F21QaBcIb26rzwPTw/PntGQuQ/qw2EnY E6HF8HUTcfHFEw==; In-Reply-To: <391fb6f4-163e-45fb-e2f9-311382e0ad93@gutov.dev> (message from Dmitry Gutov on Thu, 5 Oct 2023 13:48:55 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271927 Archived-At: > Date: Thu, 5 Oct 2023 13:48:55 +0300 > Cc: eggert@cs.ucla.edu, cph@chris-hanson.org, gregory@heytings.org, > gerd.moellmann@gmail.com, 66288@debbugs.gnu.org > From: Dmitry Gutov > > On 05/10/2023 08:50, Eli Zaretskii wrote: > >> Date: Thu, 5 Oct 2023 01:54:43 +0300 > >> Cc:gregory@heytings.org,gerd.moellmann@gmail.com,66288@debbugs.gnu.org > >> From: Dmitry Gutov > >> > >> On 05/10/2023 01:49, Paul Eggert wrote: > >>>> +      fcntl (inchannel, F_SETPIPE_SZ, readmax); > >>> This call can fail if you aren't root and you exceed the system limit in > >>> /proc/sys/fs/pipe-max-size. So I suggest that if this fnctl fails with > >>> EPERM, trying it again after clipping to that limit. > >> Perhaps we'd rather fail loudly, so the user is aware that their > >> customized value cannot be applied. > > Why not silently? The clip_to_bounds call can already silently change > > the original request anyway. > > clip_to_bounds clips to 4294967296 or higher, if I'm not mistaken. And > my current system-wide limit is 1048576. > > I usually like to know when my applied configuration is not used (or > use-able). Anyway, it's not a hard requirement (not for emacs-29 anyway). OK, I installed the change on the emacs-29 branch, and I'm therefore closing this bug.