From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67269: 30.0.50; italic face fallback does not assume italic properties Date: Mon, 20 Nov 2023 13:55:10 +0200 Message-ID: <838r6sk5b5.fsf@gnu.org> References: <87jzqejn8f.fsf.ref@yahoo.com> <87jzqejn8f.fsf@yahoo.com> <83leaul03g.fsf@gnu.org> <87bkbqjk97.fsf@yahoo.com> <83h6likvgc.fsf@gnu.org> <8734x1kjg1.fsf@yahoo.com> <83wmudkihf.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31488"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67269@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 20 12:57:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r52u6-0007um-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Nov 2023 12:57:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r52ti-0004DN-8t; Mon, 20 Nov 2023 06:57:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r52tg-0004DD-RM for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 06:57:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r52tg-0002Bj-IZ for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 06:57:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r52ti-0004ad-AG for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 06:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2023 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67269 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 67269-submit@debbugs.gnu.org id=B67269.170048137117561 (code B ref 67269); Mon, 20 Nov 2023 11:57:02 +0000 Original-Received: (at 67269) by debbugs.gnu.org; 20 Nov 2023 11:56:11 +0000 Original-Received: from localhost ([127.0.0.1]:52639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r52st-0004ZB-9C for submit@debbugs.gnu.org; Mon, 20 Nov 2023 06:56:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r52so-0004Ya-0g for 67269@debbugs.gnu.org; Mon, 20 Nov 2023 06:56:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r52sd-0001yo-IR; Mon, 20 Nov 2023 06:55:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XbOzMMfQqoNwz0FnAphVGxJS0KbwricRX6yGNl6HhcA=; b=f18zvJOQg7jT Y4CX+xukqO9TkVIEwJmB9d4FGdbIc2JTL4AYpU0GyW0BE+e5GL//qphlvVheajnyBWdFPXLypfl+X VZrz+WCRlFivnNQsP/L5QoGi2feGlus/SaaH80R1D00qT88ylyT/B1HWSDBU1jTM/41MUoj28+uka zJP1YvlhLTx8uG7eXFupssLGxT2fADDylaWk93gItv0LoTLu+lpL+IWV+7CvSwtXdx+lkQ1YQz5da iQ50TXjReuNtO17EpzSLmKPshnDamn9z0BbbDWjMmvVbnjToab+XQIfXF8BGwcEeCy6RxU1zMYH1v Gdo//BJSCWGEUTfFoLgOqQ==; In-Reply-To: (message from Po Lu on Mon, 20 Nov 2023 08:22:35 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274656 Archived-At: > From: Po Lu > Cc: 67269@debbugs.gnu.org > Date: Mon, 20 Nov 2023 08:22:35 +0800 > > Eli Zaretskii writes: > > > Then maybe we should change the default fontset's definition on > > Android (if those are the systems you have in mind). We already do > > that for w32, see w32-standard-fontset-spec as opposed to > > standard-fontset-spec. > > The systems I have in mind aren't only Android: Noto Sand Mono is the > default (or only) Monospace font on many GNU/Linux systems as well, and > I've also witnessed DejaVu Sans Mono being installed without an Italic > variant. If so, then it is strange that we haven't heard about this issue before. Maybe we should do something like the below, and leave the rest to end users and downstream distros. > > I don't understand how shr-tag-i is relevant. I'm probably missing > > something. > > It combines a variable pitch face with italic, and so loses when the > italic face doesn't support slant properties, even if the variable pitch > one does. Yes, you already said that in your original message. I thought shr-tag-i provides some additional insight. diff --git a/lisp/faces.el b/lisp/faces.el index 7eacc40..8eaabbf 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -2440,7 +2440,10 @@ italic '((((supports :slant italic)) :slant italic) (((supports :underline t)) - :underline t) + ;; Include italic, even if it isn't supported by the default + ;; font, because this face could be merged with another face + ;; which uses font that does have an italic variant. + :underline t :slant italic) (t ;; Default to italic, even if it doesn't appear to be supported, ;; because in some cases the display engine will do its own @@ -2457,7 +2460,9 @@ bold-italic (defface underline '((((supports :underline t)) :underline t) - (((supports :weight bold)) + ;; Include underline, for when this face is merged with another + ;; whose font does support underline. + (((supports :weight bold :underline t)) :weight bold) (t :underline t)) "Basic underlined face."