From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de
Subject: bug#68083: 30.0.50; Intermittent build failure with native compilation
Date: Sat, 30 Dec 2023 19:42:54 +0200 [thread overview]
Message-ID: <838r5b4me9.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48yHsfN=efOhtmquWThSkfPLvC1B-=v_xs=ySf1fR7poiQ@mail.gmail.com> (message from Aaron Jensen on Sat, 30 Dec 2023 10:29:16 -0500)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Sat, 30 Dec 2023 10:29:16 -0500
> Cc: acorallo@gnu.org, 68083@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de
>
> On Sat, Dec 30, 2023 at 1:47 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > Are you sure? We do that on Windows because Windows doesn't allow us
> > to delete a file that is open by another program. That shouldn't
> > happen on Posix systems, so I think what you see here is due to a race
> > between checking whether a file exists and renaming it, which is a
> > different problem.
> >
> > However, feel free to try the same trick we use on Windows and see
> > whether it helps.
>
> This fixes it for me:
>
> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> index 3b2fd25e61c..80088f935a4 100644
> --- a/lisp/emacs-lisp/comp.el
> +++ b/lisp/emacs-lisp/comp.el
> @@ -3341,7 +3341,11 @@ comp-delete-or-replace-file
> ;; is currently loaded.
> (t (delete-file oldfile)
> (when newfile
> - (rename-file newfile oldfile)))))
> + (condition-case _
> + (rename-file newfile oldfile)
> + (file-already-exists
> + (delete-file newfile)
> + t))))))
What happens if, instead of wrapping rename-file in condition-case,
you change that to say
(t (if newfile
(rename-file newfile oldfile)
(delete-file oldfile))
> I imagine that this is worth doing just to make this operation
> parallel-safe, but I wonder why macroexpand is the only instance of
> this happening. I don't know if macroexpand should still be in
> native-comp-never-optimize-functions or not (i.e., is there another
> reason it was there other than to avoid this crash?)
rename-file is supposed to be an atomic operation on Posix
filesystems, so I don't quite understand why you see what you see, and
I'm hesitant to sweep under the carpet a problem we don't understand.
next prev parent reply other threads:[~2023-12-30 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 14:05 bug#68083: 30.0.50; Intermittent build failure with native compilation Aaron Jensen
2023-12-28 15:12 ` Eli Zaretskii
2023-12-29 18:43 ` Andrea Corallo
2023-12-29 19:09 ` Aaron Jensen
2023-12-29 20:17 ` Andrea Corallo
2023-12-29 20:26 ` Aaron Jensen
2023-12-29 21:07 ` Aaron Jensen
2023-12-30 6:47 ` Eli Zaretskii
2023-12-30 15:29 ` Aaron Jensen
2023-12-30 17:42 ` Eli Zaretskii [this message]
2023-12-30 18:06 ` Aaron Jensen
2023-12-30 18:46 ` Eli Zaretskii
2023-12-30 20:54 ` Aaron Jensen
2023-12-30 23:08 ` Aaron Jensen
2023-12-31 6:26 ` Eli Zaretskii
2024-01-01 19:39 ` Andrea Corallo
2024-01-01 20:12 ` Eli Zaretskii
2023-12-31 20:30 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838r5b4me9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68083@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=acorallo@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.