From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#4448: 23.1; unrmail fails if buffer has mixed line endings (patch) Date: Wed, 16 Sep 2009 20:17:38 +0300 Message-ID: <837hvyyfkd.fsf@gnu.org> References: Reply-To: Eli Zaretskii , 4448@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1253122041 14314 80.91.229.12 (16 Sep 2009 17:27:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Sep 2009 17:27:21 +0000 (UTC) To: "David J. Biesack" , 4448@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 16 19:27:13 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MnyHh-0004sp-AU for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2009 19:27:13 +0200 Original-Received: from localhost ([127.0.0.1]:48203 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnyHg-0002OV-Af for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2009 13:27:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnyHb-0002OE-Vd for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 13:27:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnyHX-0002Nu-I3 for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 13:27:07 -0400 Original-Received: from [199.232.76.173] (port=36792 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnyHX-0002Nr-CM for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 13:27:03 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46709) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MnyHW-0006Jr-QK for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 13:27:03 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8GHR05O016305; Wed, 16 Sep 2009 10:27:00 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8GHP897015965; Wed, 16 Sep 2009 10:25:08 -0700 Resent-Date: Wed, 16 Sep 2009 10:25:08 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 16 Sep 2009 17:25:07 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4448 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4448-submit@emacsbugs.donarmstrong.com id=B4448.125312146314731 (code B ref 4448); Wed, 16 Sep 2009 17:25:07 +0000 Original-Received: (at 4448) by emacsbugs.donarmstrong.com; 16 Sep 2009 17:17:43 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout7.012.net.il (mtaout7.012.net.il [84.95.2.19]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8GHHf7t014718 for <4448@emacsbugs.donarmstrong.com>; Wed, 16 Sep 2009 10:17:43 -0700 Original-Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KQ200100QL4PH00@i-mtaout7.012.net.il> for 4448@emacsbugs.donarmstrong.com; Wed, 16 Sep 2009 20:17:35 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.70.38.189]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KQ200AZOQPAXR70@i-mtaout7.012.net.il>; Wed, 16 Sep 2009 20:17:34 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 16 Sep 2009 13:27:07 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31145 Archived-At: > Date: Wed, 16 Sep 2009 09:28:35 -0400 > From: "David J. Biesack" > Cc: > > > I invoked rmail-input on an RMAIL file and got the following traceback. > > I performed find-file-literally on the rmail file and found that > it has mixed line endings - text text of the first messages end in just LF and > others end in CR LF. This causes the > > (re-search-forward "^[*][*][*] EOOH [*][*][*]\n") > > in unrmail to fail. Yes, by design (although the traceback is not by design). > Here is a patch which makes it work, but I don't think this is the correct > change; it seems that the correct change would be to account for coding > systems. Actually, I think the correct change would be to throw an error with a meaningful error message. Babyl files written by Rmail are supposed to have Unix EOLs. Of course, entering the debugger is not a graceful reaction, but I don't think we should support incorrectly formatted Babyl files. That way lies madness. Thanks.