From: Eli Zaretskii <eliz@gnu.org>
To: "David J. Biesack" <David.Biesack@sas.com>,
4448@emacsbugs.donarmstrong.com
Subject: bug#4448: 23.1; unrmail fails if buffer has mixed line endings (patch)
Date: Wed, 16 Sep 2009 20:17:38 +0300 [thread overview]
Message-ID: <837hvyyfkd.fsf@gnu.org> (raw)
In-Reply-To: <ytbr5u7m324.fsf@sas.com>
> Date: Wed, 16 Sep 2009 09:28:35 -0400
> From: "David J. Biesack" <David.Biesack@sas.com>
> Cc:
>
>
> I invoked rmail-input on an RMAIL file and got the following traceback.
>
> I performed find-file-literally on the rmail file and found that
> it has mixed line endings - text text of the first messages end in just LF and
> others end in CR LF. This causes the
>
> (re-search-forward "^[*][*][*] EOOH [*][*][*]\n")
>
> in unrmail to fail.
Yes, by design (although the traceback is not by design).
> Here is a patch which makes it work, but I don't think this is the correct
> change; it seems that the correct change would be to account for coding
> systems.
Actually, I think the correct change would be to throw an error with a
meaningful error message. Babyl files written by Rmail are supposed
to have Unix EOLs. Of course, entering the debugger is not a graceful
reaction, but I don't think we should support incorrectly formatted
Babyl files. That way lies madness.
Thanks.
next prev parent reply other threads:[~2009-09-16 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 13:28 bug#4448: 23.1; unrmail fails if buffer has mixed line endings (patch) David J. Biesack
2009-09-16 17:17 ` Eli Zaretskii [this message]
2009-09-16 17:48 ` David J. Biesack
2009-09-16 20:33 ` Eli Zaretskii
2009-09-17 12:58 ` David J. Biesack
2009-09-17 14:06 ` Stefan Monnier
2009-09-17 14:56 ` David J. Biesack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837hvyyfkd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=4448@emacsbugs.donarmstrong.com \
--cc=David.Biesack@sas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.