all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
@ 2010-07-29 15:59 Dan Nicolaescu
  2010-07-29 16:40 ` Óscar Fuentes
  2010-07-29 17:55 ` Eli Zaretskii
  0 siblings, 2 replies; 4+ messages in thread
From: Dan Nicolaescu @ 2010-07-29 15:59 UTC (permalink / raw)
  To: 6754


nt/config.nt:#undef TIME_WITH_SYS_TIME

src/s/ms-w32.h:#define TIME_WITH_SYS_TIME 1

These seems to contradict each other. Aren't these files used on the same platform?





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
  2010-07-29 15:59 bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h Dan Nicolaescu
@ 2010-07-29 16:40 ` Óscar Fuentes
  2010-07-29 17:55 ` Eli Zaretskii
  1 sibling, 0 replies; 4+ messages in thread
From: Óscar Fuentes @ 2010-07-29 16:40 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 6754

Dan Nicolaescu <dann@gnu.org> writes:

> nt/config.nt:#undef TIME_WITH_SYS_TIME
>
> src/s/ms-w32.h:#define TIME_WITH_SYS_TIME 1
>
> These seems to contradict each other. Aren't these files used on the
> same platform?

Yes.

It is clear that config.nt and msw-32.h are trying to be the same.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
  2010-07-29 15:59 bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h Dan Nicolaescu
  2010-07-29 16:40 ` Óscar Fuentes
@ 2010-07-29 17:55 ` Eli Zaretskii
  2010-08-02 23:24   ` Juanma Barranquero
  1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2010-07-29 17:55 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 6754

> From: Dan Nicolaescu <dann@gnu.org>
> Date: Thu, 29 Jul 2010 11:59:15 -0400
> Cc: 
> 
> 
> nt/config.nt:#undef TIME_WITH_SYS_TIME
> 
> src/s/ms-w32.h:#define TIME_WITH_SYS_TIME 1
> 
> These seems to contradict each other. Aren't these files used on the same platform?

It seems to be a left-over from long ago.  Once upon a time, Windows
headers didn't have sys/time.h (MSVC still doesn't, but MinGW now
does), so nt/config.nt disabled its use.  Later, nt/inc/sys/time.h was
added to work around this, but the #undef was not removed.  Since
ms-w32.h is included _after_ the #undef, it did no harm.

Bottom line: the #undef in config.nt can be removed.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h
  2010-07-29 17:55 ` Eli Zaretskii
@ 2010-08-02 23:24   ` Juanma Barranquero
  0 siblings, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2010-08-02 23:24 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Dan Nicolaescu, 6754-done

On Thu, Jul 29, 2010 at 19:55, Eli Zaretskii <eliz@gnu.org> wrote:

> Bottom line: the #undef in config.nt can be removed.

Done.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-08-02 23:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-29 15:59 bug#6754: TIME_WITH_SYS_TIME in nt/config.nt and src/s/ms-w32.h Dan Nicolaescu
2010-07-29 16:40 ` Óscar Fuentes
2010-07-29 17:55 ` Eli Zaretskii
2010-08-02 23:24   ` Juanma Barranquero

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.